Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v24.1.x] gha/promote: fix trigger promote action #25212

Merged
merged 5 commits into from
Feb 28, 2025
Merged

[v24.1.x] gha/promote: fix trigger promote action #25212

merged 5 commits into from
Feb 28, 2025

Conversation

andrewhsu
Copy link
Member

@andrewhsu andrewhsu commented Feb 27, 2025 •
edited by jira bot
Loading

Fixes #25210
Backport of PR #25207
jira: DEVPROD-2679 CORE-9234

resolved conflict by backporting 2 extra commits edeb97d 0abd1f6, and then cherry-picks were clean:

bash$ git cherry-pick -x edeb97d 0abd1f6 81471c9 47fe54b ad02623
Auto-merging .github/workflows/promote.yml
[DEVPROD-2679-fix-promote-v24.1.x ad4fb4914d] gha: update actions in promote.yml
 Date: Sat Sep 21 19:32:37 2024 -0500
 1 file changed, 1 insertion(+), 2 deletions(-)
Auto-merging .github/workflows/promote.yml
[DEVPROD-2679-fix-promote-v24.1.x 9769f9c272] gha: use full major.minor.patch version ID
 Author: Ivo Jimenez <[email protected]>
 Date: Tue Dec 3 08:17:08 2024 -0700
 1 file changed, 1 insertion(+), 1 deletion(-)
[DEVPROD-2679-fix-promote-v24.1.x 8be9d3490b] gha/promote: pin run on ubuntu 24.04
 Date: Thu Feb 27 11:11:10 2025 -0800
 1 file changed, 1 insertion(+), 1 deletion(-)
[DEVPROD-2679-fix-promote-v24.1.x eb9a5153db] gha/promote: update to latest buildkite/trigger-pipeline-action
 Date: Thu Feb 27 11:13:07 2025 -0800
 1 file changed, 1 insertion(+), 1 deletion(-)
[DEVPROD-2679-fix-promote-v24.1.x 9ce2ea04b6] gha/promote: use PIPELINE_ACTION=promote-from-staging
 Date: Thu Feb 27 11:16:34 2025 -0800
 1 file changed, 1 insertion(+), 1 deletion(-)

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

andrewhsu and others added 5 commits February 27, 2025 15:48
@andrewhsu
gha: update actions in promote.yml
ad4fb49 
(cherry picked from commit edeb97d)
@ivotron @andrewhsu
gha: use full major.minor.patch version ID
9769f9c 
This was changed in a previous commit and while it was working OK, it is
now failing.

Signed-off-by: Ivo Jimenez <[email protected]>
(cherry picked from commit 0abd1f6)
@andrewhsu
gha/promote: pin run on ubuntu 24.04
8be9d34 
No functionality change.

Protect against future `ubuntu-latest` breaking changes.

(cherry picked from commit 81471c9)
@andrewhsu
gha/promote: update to latest buildkite/trigger-pipeline-action
eb9a515 
No functionality change expected.

See changes:
buildkite/trigger-pipeline-action@v2.0.0...v2.3.0

(cherry picked from commit 47fe54b)
@andrewhsu
gha/promote: use PIPELINE_ACTION=promote-from-staging
9ce2ea0 
The PIPELINE_ACTION is the expected driving env var for the buildkite
dynamic pipeline.

(cherry picked from commit ad02623)
@andrewhsu andrewhsu force-pushed the DEVPROD-2679-fix-promote-v24.1.x branch from 151fd9a to 9ce2ea0 Compare February 27, 2025 23:48
@andrewhsu andrewhsu added the kind/backport PRs targeting a stable branch label Feb 27, 2025
@andrewhsu andrewhsu added this to the v24.1.x-next milestone Feb 27, 2025
@andrewhsu andrewhsu linked an issue Feb 27, 2025 that may be closed by this pull request
[v24.1.x] gha/promote: fix trigger promote action #25210
Open
@andrewhsu andrewhsu marked this pull request as ready for review February 27, 2025 23:50
@andrewhsu andrewhsu requested a review from a team as a code owner February 27, 2025 23:50
@andrewhsu andrewhsu requested review from redpanda-gandalf and rpdevmp and removed request for a team February 27, 2025 23:50
@andrewhsu andrewhsu enabled auto-merge February 27, 2025 23:50
@andrewhsu andrewhsu requested review from gousteris and removed request for redpanda-gandalf February 27, 2025 23:51
rpdevmp
rpdevmp approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@rpdevmp rpdevmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit 2c2fa11 into v24.1.x Feb 28, 2025
13 checks passed
@andrewhsu andrewhsu deleted the DEVPROD-2679-fix-promote-v24.1.x branch February 28, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpdevmp rpdevmp rpdevmp approved these changes

@gousteris gousteris Awaiting requested review from gousteris

Assignees
No one assigned
Labels
area/build kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v24.1.x-next
Development

Successfully merging this pull request may close these issues.

[v24.1.x] gha/promote: fix trigger promote action
3 participants
@andrewhsu @rpdevmp @ivotron