Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-962 Field additions and deprecations for redpanda_migrator_offsets output #152

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

asimms41
Copy link
Collaborator

@asimms41 asimms41 commented Jan 21, 2025

Description

Resolves DOC-962 (Field additions and deprecations)
Review deadline: 21st January

Page previews

redpanda_migrator_offsets output

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for redpanda-connect ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-connect/deploys/67990ad83e2f10006a00e2b9
😎 Deploy Preview https://deploy-preview-152--redpanda-connect.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asimms41 asimms41 requested a review from mihaitodor January 21, 2025 11:23
@asimms41 asimms41 changed the title Update fields DOC-962 Field additions and deprecations for redpanda_migrator_offsets output Jan 21, 2025
Copy link
Collaborator

@mihaitodor mihaitodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor changes. Feel free to :shipit:

@asimms41 asimms41 marked this pull request as ready for review January 21, 2025 16:00
@asimms41 asimms41 requested a review from a team as a code owner January 21, 2025 16:00
@asimms41 asimms41 requested a review from mihaitodor January 21, 2025 16:00
Copy link
Collaborator

@mihaitodor mihaitodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :shipit:

@asimms41 asimms41 requested a review from JakeSCahill January 22, 2025 12:35
@JakeSCahill
Copy link
Contributor

Do we maintain a list of deprecations for RPCN?

@asimms41
Copy link
Collaborator Author

Do we maintain a list of deprecations for RPCN?

Only in What's new, but I have a ticket for a deprecation feature which is on the backlog.

@asimms41 asimms41 merged commit 0fc50e6 into main Jan 28, 2025
5 checks passed
@asimms41 asimms41 deleted the DOC-962_Updates_to_redpanda_migrator_offsets_output branch January 28, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants