Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement custom slice creators #3894

Open
wants to merge 208 commits into
base: master
Choose a base branch
from
Open

Implement custom slice creators #3894

wants to merge 208 commits into from
+3,611 −1,060

Conversation

EskiMojo14
Copy link
Collaborator

@EskiMojo14 EskiMojo14 commented Nov 18, 2023 •
edited
Loading

see #3837

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Nov 18, 2023

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Nov 18, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2d7def1:

Sandbox Source
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

phryneas
phryneas reviewed Nov 18, 2023
View reviewed changes
packages/toolkit/src/tsHelpers.ts Outdated Show resolved Hide resolved
packages/toolkit/tsconfig.base.json Outdated Show resolved Hide resolved
@netlify Netlify
Copy link

netlify bot commented Nov 18, 2023

✅ Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit cad9cb9
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/6559408882294e00080491ae
😎 Deploy Preview https://deploy-preview-3894--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 18, 2023 •
edited
Loading

✅ Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 2d7def1
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/67499e3cf25cbc0008de346f
😎 Deploy Preview https://deploy-preview-3894--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EskiMojo14 EskiMojo14 added this to the Post 2.0 milestone Nov 19, 2023
Base automatically changed from v2.0-integration to master December 4, 2023 04:51
EskiMojo14 and others added 15 commits December 4, 2023 12:18
@EskiMojo14
Merge branch 'master' into create-slice-creators
aa5aae6
@EskiMojo14
remove underscore
346f227
@EskiMojo14
update errors.json
295eebc
@EskiMojo14
remove unnecessary rename
0e676b6
@EskiMojo14
add condition creator test
3f502c2
@EskiMojo14
check promise status synchronously
e21a7da
@EskiMojo14
use resolves chain
f725ab6
@EskiMojo14
shuffle creator locations
640b9c5
@EskiMojo14
add multireducer creator example
0d7669d
@EskiMojo14
use symbols for reducer types, for clarity
604799a
@aryaemami59
Modify BuildCreateSliceConfig to allow passing asyncThunk by defa…
888e886 
…ult and prevent passing of `reducer` and `reducerWithPrepare`

  - Changed `BuildCreateSliceConfig` to allow passing `asyncThunk` without sacrificing autocompletion.
  - Implemented type constraints to disallow usage of `reducer` and `reducerWithPrepare`, removing them from autocomplete suggestions.
@aryaemami59
Fix typo from reducerWithPrepare -> preparedReducer
5cc5509
@EskiMojo14
expose getInitialState to reducer creators
0d60f50
@EskiMojo14
tweak creators type to prevent autocomplete of banned keys
a993d91
@EskiMojo14
change default back
bb8cd15
@EskiMojo14 EskiMojo14 mentioned this pull request May 3, 2024
Merged
EskiMojo14 and others added 19 commits May 22, 2024 11:05
@EskiMojo14
Merge branch 'master' into create-slice-creators
5fe391e
@EskiMojo14
move async thunk creator module augmentation
f8ad517
@EskiMojo14
try something different
cdf4498
@EskiMojo14
tweak example
2d08f5d
@EskiMojo14
add note about exposing multiple values per reducer def
6226c1d
@EskiMojo14
add note about addMatcher order
ce04544
@EskiMojo14
limit recursion depth of definition extraction
32cdde8
@EskiMojo14
rm unused type
0f01293
@EskiMojo14
guard against strange behaviour of OverloadedReturnType in pre 5.3 ve…
45c8b9e 
…rsions
@EskiMojo14
condense OverloadedReturnType since first conditional is always hit
99c0c7f
@EskiMojo14
remove note re: addMatcher order as it doesn't apply
62e96d5
@EskiMojo14
remove requirement for create to be a function
a12524a
@EskiMojo14
test non-function creator
e99e084
@EskiMojo14
Merge branch 'master' into create-slice-creators
3ec07e9
@EskiMojo14
fix type portability examples
b6d1d5d
@EskiMojo14
Merge branch 'master' into create-slice-creators
e9744e0
@EskiMojo14
switch back to an interface
b10f345
@EskiMojo14
avoid relative declaration
ef2d024
@EskiMojo14
Merge branch 'master' into create-slice-creators
2d7def1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phryneas phryneas phryneas left review comments

@markerikson markerikson markerikson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Post 2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@EskiMojo14 @markerikson @phryneas @aryaemami59