-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add option to disable sync mode #31
base: main
Are you sure you want to change the base?
Conversation
Thank you. Sorry for late reply. I will check your PR. |
@Matthiee CI fails. Is it OK to ignore this error?
|
Hi @rot1024, The goal here would be to have no memory retained hence I put the expected value at 0. However, I was unable to achieve this. I already created this draft PR to demonstrate some ways of reducing the memory when not using the syncing capabilities of the library. There is still I was hoping that you could also have a look to see if maybe there is a better way of doing this or if I'm missing something here. More info on my original issue can be found here #30 Kind regards, |
Doesn't fully fix #30 but drastically reduces memory being retained in
QuickJSRuntime
.I added 2 test cases to demonstrate this.
Table with memory increases after 100 iterations: