Manual cache #9
Open
Manual cache #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Epic! We should make sure it's well tested though |
Comment on lines
-25
to
-30
| options.cachePath = self.cachePath; | ||
| options.cacheIdentifier = self.cacheIdentifier; | ||
| options.defaultExpirationPeriod = 60 * 60 * 24 * 30; | ||
| options.garbageCollectionInterval = (NSUInteger)(1.5 * SPTPersistentCacheDefaultGCIntervalSec); | ||
| options.sizeConstraintBytes = 1024 * 1024 * 100; | ||
| options.useDirectorySeparation = NO; |
There was a problem hiding this comment.
Where did all this config go?
|
^ Updated with export from iOS cache |
jaspermeijaard
pushed a commit
that referenced
this pull request
Jun 24, 2022
Add support for L1 to L3 Widevine fallback if playback fails initially.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For both iOS and Android this allows setting the cache from outside of the package so we can configure the parameters in JS.
Android specific: the changes in ExoPlayerCache make sure we always export the full video. Previously the video cache would cache the video in 5 MB parts, the export code would download the full video again (and cache it in a full X MB file).
Now: The datasource first loads from the video player cache, if a part is missing or incomplete it will use the dataspec to download the missing bits. This should solve the export issue and significantly speed things up since it can now benefit from the video player cache while exporting!
Still needs a bit of cleanup :)
Mobileapp PR will follow tomorrow!