Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split unstable_clientMiddleware export into its own chunk #12961

Open
wants to merge 2 commits into
base: brophdawg11/feat-middleware
Choose a base branch
from

Conversation

markdalgleish
Copy link
Member

Note, this PR is targeting the brophdawg11/feat-middleware branch.

Luckily this turned out to be fairly straightforward. The route manifest now has hasClientMiddleware and clientMiddlewareModule fields. It follows the same pattern as clientLoader/clientAction/HydrateFallback where the manifest allows you to dynamically load the unstable_clientMiddleware export if it's in its own chunk, otherwise you can fall back to loading it from the main route module. Note that this behaviour is also guarded behind the future.unstable_splitRouteModules flag, so it might be a good idea to encourage turning this flag on when using client middleware given the performance implications.

Copy link

changeset-bot bot commented Feb 6, 2025

⚠️ No Changeset found

Latest commit: 2336f3d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant