Skip to content

fix(react-router): fix regex handling for URLs containing newline characters #13643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

rururux
Copy link

@rururux rururux commented May 20, 2025

Currently, with the implementation of compilePath, routes like /* do not match when the URL starts with a newline character (%0A).
This is because the regular expression generated in the compilePath function does not have the s (single line) flag set.
This PR adds the s flag to the regular expression used for route matching and includes test cases to verify the behavior.

Copy link

changeset-bot bot commented May 20, 2025

⚠️ No Changeset found

Latest commit: 55413d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 20, 2025

Hi @rururux,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 20, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title fix regex handling for URLs containing newline characters (%0A) (#13490) fix(react-router): fix regex handling for URLs containing newline characters May 20, 2025
@MichaelDeBoey MichaelDeBoey linked an issue May 20, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL Parsing Error Due to Newline Character Inclusion
3 participants