Skip to content

feat: use ?inline to load critical styles #10254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

sapphi-red
Copy link

The default export of css files was removed in Vite v5, but it was accidently left for SSR. Vite v6 removes that (vitejs/vite#17922). This PR changes the critical style loader to use ?inline imports to make remix compatible with Vite v6.

Testing Strategy: I ran pnpm i && pnpm vite-ecosystem-ci:build && pnpm vite-ecosystem-ci:test with both Vite 5.x and 6.x.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 21, 2024

Hi @sapphi-red,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

Copy link

changeset-bot bot commented Nov 21, 2024

🦋 Changeset detected

Latest commit: dad7725

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@remix-run/dev Minor
@remix-run/fs-routes Minor
@remix-run/route-config Minor
@remix-run/routes-option-adapter Minor
create-remix Minor
remix Minor
@remix-run/architect Minor
@remix-run/cloudflare Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/css-bundle Minor
@remix-run/deno Minor
@remix-run/eslint-config Minor
@remix-run/express Minor
@remix-run/node Minor
@remix-run/react Minor
@remix-run/serve Minor
@remix-run/server-runtime Minor
@remix-run/testing Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 21, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you point this at the dev branch instead, and add a changeset?

@sapphi-red sapphi-red changed the base branch from main to dev December 16, 2024 00:59
@sapphi-red sapphi-red force-pushed the feat/vite6-css-default-export branch from 297fbd9 to dad7725 Compare December 16, 2024 01:12
@sapphi-red
Copy link
Author

Sure. I pointed to the dev branch and added a changeset 👍

Copy link
Contributor

Thank you for opening this pull request, and our apologies we haven't gotten around to it yet!

With the release of React Router v7 we are sun-setting continued development/maintenance on Remix v2. If you have not already upgraded to React Router v7, we recommend you do so. We've tried to make the upgrade process as smooth as possible with our Future Flags. We are now in the process of cleaning up outdated issues and pull requests to improve the overall hygiene of our repositories.

We plan to continue to address 2 types of issues in Remix v2:

  • Bugs that pose security concerns
  • Bugs that prevent upgrading to React Router v7

If you believe this pull request meets one of those criteria, please respond or create a new pull request so it pops up on our radar (since github notifications may get lost in the noise 😕).

For all other issues/changes, ongoing maintenance will be happening in React Router v7, so:

  • If this is a bug fix, please reopen against React Router v7
  • If this is a new feature, please open a new Proposal Discussion in React Router, and if it gets enough community support it can be considered for implementation

If you have any questions you can always reach out on Discord. Thanks again for providing feedback and helping us make our framework even better!

@github-actions github-actions bot closed this May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants