Skip to content

fix(remix-serve): remove redundant @remix-run/node/install import #10306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kt3k
Copy link
Contributor

@kt3k kt3k commented Dec 5, 2024

remix-serve cli seems calling installGlobals function of @remix-run/node package twice. In my usage, it's called with 2 different nativeFetch flags and that seems causing unnecessary dependency (@remix-run/web-fetch) loaded on the server runtime.

This PR removes the first call of installGlobals (by removing import of @remix-run/node/install), and tries to avoid the above situation.

Copy link

changeset-bot bot commented Dec 5, 2024

🦋 Changeset detected

Latest commit: aeab7a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@remix-run/serve Patch
@remix-run/react Patch
@remix-run/dev Patch
@remix-run/testing Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/fs-routes Patch
@remix-run/node Patch
@remix-run/route-config Patch
@remix-run/routes-option-adapter Patch
@remix-run/server-runtime Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 5, 2024

Hi @kt3k,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 5, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title refactor: remove redundant '@remix-run/node/install' import fix(remix-serve): remove redundant '@remix-run/node/install' import Dec 5, 2024
@kt3k
Copy link
Contributor Author

kt3k commented Dec 11, 2024

Note:

@MichaelDeBoey MichaelDeBoey changed the title fix(remix-serve): remove redundant '@remix-run/node/install' import fix(remix-serve): remove redundant @remix-run/node/install import Jan 23, 2025
@brophdawg11
Copy link
Contributor

Thanks for the PR! Would you mind repointing this to the dev branch?

"@remix-run/serve": patch
---

Remove redundant '@remix-run/node/install' import
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Remove redundant '@remix-run/node/install' import
Remove redundant '@remix-run/node/install' import from `remix-serve` because it manually calls `installGlobals` separately

@kt3k kt3k changed the base branch from main to dev May 2, 2025 14:08
@brophdawg11 brophdawg11 merged commit deb502a into remix-run:dev May 2, 2025
9 checks passed
Copy link
Contributor

github-actions bot commented May 3, 2025

🤖 Hello there,

We just published version v0.0.0-nightly-deb502a6d-20250503 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@kt3k kt3k deleted the perf-remove-redundant-install-globals branch May 3, 2025 16:22
Copy link
Contributor

github-actions bot commented May 8, 2025

🤖 Hello there,

We just published version v0.0.0-nightly-deb502a6d-20250503 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

github-actions bot commented May 8, 2025

🤖 Hello there,

We just published version v0.0.0-nightly-deb502a6d-20250503 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants