fix: Allow subclass methods of Headers to be called correctly #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where subclass methods of
Headers
were not being called correctly.Problem
When a class extends
Headers
, the subclass's methods (likeappend
) were not accessible or called properly. This was caused by theProxy
instance in theHeaders
constructor, which intercepted method calls and directed them to theURLSearchParams
prototype, bypassing any overrides defined in subclasses.Solution
Proxy
from the constructor.Headers
class to maintain the expected behavior and allowing overrides by subclasses.Example
cc: @mjackson