Update dependencies and refactor test configurations #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Noticed a GH action once chose podman and failed/flaked there.)
Noticing the cache isn't hitting when action runs. Remove hardcoded composer cache directory. Remove wildcard .* in Laravel version as part of cache key. Bump actions/cache to 3.3.1 (via @V3).
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Please update the following actions to use Node.js 20: actions/cache@v3, codecov/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
@rennokki This is ready for review/approval. I'd like to catch this library up and then add new k8s APIs and features (separate PRs). |
* Update CI workflow to latest versions - Upgrade PHP versions to 8.3, 8.4 (latest stable) - Update Kubernetes versions to 1.31.10, 1.32.6, 1.33.2 (current supported) - Upgrade Laravel to 11.*, 12.* with corresponding testbench versions - Update minikube to 1.36.0 (latest stable) - Upgrade codecov action to v5 - Update README badges to reflect new Kubernetes versions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Update composer dependencies for Laravel 11/12 and PHP 8.3/8.4 - Set minimum PHP version to ^8.3 - Update Laravel dependencies to support ^11.0 < /dev/null | ^12.0 - Upgrade Guzzle to ^7.0 (remove 6.x support) - Update dev dependencies: - mockery/mockery: ^1.6 - orchestra/testbench: ^9.0|^10.0 - phpunit/phpunit: ^10.0|^11.0 - vimeo/psalm: ^6.12.0 - Update composer/semver to ^3.4 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Fix PHPUnit data provider compatibility Make environmentVariableContextProvider static to support PHPUnit 10+ 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Update PHPUnit configuration for v11 compatibility - Update XML schema to vendor/phpunit/phpunit/phpunit.xsd - Use modern <source> element for coverage filtering - Set failOnWarning and failOnDeprecation to false to handle warnings gracefully - Configure proper coverage reporting with clover and text outputs 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude <[email protected]>
--- updated-dependencies: - dependency-name: symfony/process dependency-version: 7.3.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--- updated-dependencies: - dependency-name: guzzlehttp/guzzle dependency-version: 7.9.3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Add centralized container factory methods in TestCase.php to eliminate duplicate PodSpec configurations across test files. This refactoring addresses 29+ instances of duplicate MySQL, Perl, Busybox, and Nginx container setups. Key changes: - Add createMysqlContainer(), createPerlContainer(), createBusyboxContainer(), and createNginxContainer() helper methods in TestCase.php - Add createMysqlPod() and createPerlPod() helper methods for complete pod setup - Refactor 11 test files to use standardized container helpers - Maintain backward compatibility through flexible options arrays - Reduce test setup code from ~300 lines to centralized configuration Benefits: - DRY principle: single source of truth for container configurations - Improved maintainability: changes only needed in TestCase.php - Consistent container setup across all tests - Enhanced readability with self-documenting helper method names 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
@rennokki thank you for all your work so far. It would be great if we could catch this up to the latest laravel etc. |
|
As a stopgap, you can deploy from the main branch here: https://github.com/cuppett/php-k8s It has these updates and a couple other kubernetes features added. I'm waiting to see this PR get merged and then will submit PRs for those as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code