Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(manager/nuget): add support for "disabledPackageSources" in nuget.config #32011

Merged
merged 24 commits into from
Dec 6, 2024
Merged

feat(manager/nuget): add support for "disabledPackageSources" in nuget.config #32011

merged 24 commits into from
Dec 6, 2024

Conversation

Otiel
Copy link
Contributor

@Otiel Otiel commented Oct 18, 2024 •
edited
Loading

Changes

This PR adds support for the disabledPackageSources element that can be present in the nuget.config file. See the Microsoft documentation about disabledPackageSources.

Context

Closes #31379

Documentation

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins enabled auto-merge October 19, 2024 13:56
@rarkins rarkins disabled auto-merge October 19, 2024 13:56
@Otiel
Copy link
Contributor Author

Otiel commented Oct 23, 2024

@rarkins I've noticed you disabled auto-merge, was it due to a misclick when enabling auto-merge? Or is there some action still required from my part in order for you to review this PR?

@rarkins
Copy link
Collaborator

rarkins commented Oct 24, 2024

Enabling automerge was a misclick at the time

viceice
viceice reviewed Oct 24, 2024
View reviewed changes
lib/modules/manager/nuget/util.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/nuget/util.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/nuget/util.spec.ts Outdated Show resolved Hide resolved
@Otiel

This comment was marked as resolved.

Sign in to view
rarkins
rarkins requested changes Nov 7, 2024
View reviewed changes
lib/modules/manager/nuget/util.ts Outdated Show resolved Hide resolved
Otiel added 3 commits November 7, 2024 18:25
@Otiel
Fix indents
8185836
@Otiel
Remove duplicated test
a52746b 
Duplicates 'reads nuget config file without packageSources and with default registry disabled'
@Otiel
Don't attempt to treat the disabledPackageSources if there is no pack…
472a61e 
…ageSources
@Otiel Otiel requested a review from rarkins November 15, 2024 09:08
@rarkins
Copy link
Collaborator

rarkins commented Nov 15, 2024

@Otiel please don't merge from main unless it's to resolve conflicts. It resets the CI approval each time

@rarkins rarkins requested a review from viceice November 15, 2024 15:39
rarkins
rarkins requested changes Nov 15, 2024
View reviewed changes
lib/modules/manager/nuget/util.ts Outdated Show resolved Hide resolved
@rarkins rarkins enabled auto-merge November 19, 2024 05:25
auto-merge was automatically disabled November 19, 2024 07:10

Head branch was pushed to by a user without write access

rarkins
rarkins previously approved these changes Nov 19, 2024
View reviewed changes
@rarkins rarkins enabled auto-merge November 19, 2024 07:18
auto-merge was automatically disabled November 19, 2024 08:08

Head branch was pushed to by a user without write access

@Otiel

This comment was marked as resolved.

Sign in to view
@viceice viceice added auto:no-done-comments Don't say "Done" or "Please review" - request a review instead auto:no-mentions Don't cause unnecessary notifications labels Nov 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hi there,

You are using done comments which cause a lot of noise/notifications. Instead, please use GitHub's web interface to request another review. Please read our contributing guidelines to reduce noise.

Good luck,

The Renovate team

@github-actions GitHub Actions
Copy link
Contributor

Hi there,

This is intended as a polite, automated request that users avoid @ mentioning repository maintainers like @rarkins or @viceice. Doing so causes annoying mobile notifications and makes it harder to maintain this repository.

We know it might be common elsewhere but we participate in hundreds of discussions a week and would need to turn off GitHub mobile notifications if we were mentioned in every one.

As a general rule, we will read and respond to all discussions in this repository, so there is no need to mention us.

Thanks, the Renovate team

viceice
viceice reviewed Nov 19, 2024
View reviewed changes
lib/modules/manager/nuget/util.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/nuget/util.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/nuget/util.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/nuget/util.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/nuget/util.ts Show resolved Hide resolved
@viceice
Copy link
Member

viceice commented Nov 19, 2024

use GitHub re-request review button

@Otiel Otiel requested a review from viceice November 20, 2024 10:24
@rarkins rarkins enabled auto-merge November 20, 2024 11:51
@Otiel
Copy link
Contributor Author

Otiel commented Dec 5, 2024 •
edited
Loading

@viceice Sorry to bump again, it's been two weeks since I've requested a review via GitHub, so I'm wondering if you've got the notification? As the changes are minor, this should be fairly quick to review.

Thanks in advance ❤️

@rarkins rarkins added this pull request to the merge queue Dec 6, 2024
Merged via the queue into renovatebot:main with commit 9c999fb Dec 6, 2024
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.52.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Otiel Otiel deleted the feature/support-disabledPackageSources-in-nuget-config branch December 9, 2024 19:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
auto:no-done-comments Don't say "Done" or "Please review" - request a review instead auto:no-mentions Don't cause unnecessary notifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Otiel @rarkins @viceice @renovate-release