feat(branchNameStrict)!: remove forward slashes from non-prefix part of branchName #32278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will be a breaking change for us (and others) unless we coordinate setting |
viceice
approved these changes
Nov 1, 2024
rarkins
added a commit
that referenced
this pull request
Nov 4, 2024
…of branchName (#32278) Update logic for branchNameStrict=true so that it also removes forward slashes from branch names, with the exception of the `branchPrefix` part. In other words, if you leave the default `branchPrefix="renovate/"` then you'll get branch names like `renovate/foo-bar-42-x` instead of today's `renovate/foo/bar-42-x`. BREAKING CHANGE: Branch names with multiple forward slashes will change if branchNameStrict=true
rarkins
added a commit
that referenced
this pull request
Nov 4, 2024
…of branchName (#32278) Update logic for branchNameStrict=true so that it also removes forward slashes from branch names, with the exception of the `branchPrefix` part. In other words, if you leave the default `branchPrefix="renovate/"` then you'll get branch names like `renovate/foo-bar-42-x` instead of today's `renovate/foo/bar-42-x`. BREAKING CHANGE: Branch names with multiple forward slashes will change if branchNameStrict=true
rarkins
added a commit
that referenced
this pull request
Nov 4, 2024
…of branchName (#32278) Update logic for branchNameStrict=true so that it also removes forward slashes from branch names, with the exception of the `branchPrefix` part. In other words, if you leave the default `branchPrefix="renovate/"` then you'll get branch names like `renovate/foo-bar-42-x` instead of today's `renovate/foo/bar-42-x`. BREAKING CHANGE: Branch names with multiple forward slashes will change if branchNameStrict=true
rarkins
added a commit
that referenced
this pull request
Nov 4, 2024
…of branchName (#32278) Update logic for branchNameStrict=true so that it also removes forward slashes from branch names, with the exception of the `branchPrefix` part. In other words, if you leave the default `branchPrefix="renovate/"` then you'll get branch names like `renovate/foo-bar-42-x` instead of today's `renovate/foo/bar-42-x`. BREAKING CHANGE: Branch names with multiple forward slashes will change if branchNameStrict=true
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When
branchNameStrict=true, Renovate will now:branchPrefix/characters from the remaining part of the branch name (not includingbranchPrefix)This means you can choose whether you want either:
renovate/jest-42-x) by leavingbranchPrefixas is, orrenovate-jest-42-x) by also settingsbranchPrefix="renovate-"Context
The docs say that Renovate removes special characters, but previous behavior did not fully.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: