-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(maven): Reject releases only for Maven Central repository #32287
fix(maven): Reject releases only for Maven Central repository #32287
Conversation
I'm it sure this is what we want. It's private registries which have the release problems |
Another suggestion is to exclude jetbrains repo, as it doesn't seem to follow the structure we expect anyways (e.g. at the earlier stage we fail to fetch metadata xml for the latest release). |
Does that mean that that repo didn't used to work at all when we used to eagerly check releases? |
Yes, I think it never worked to the full extent, though HTML page is good enough to extract the list of versions (i.e. without metadata) |
Might be better to make this logic configurable?
|
Isn't it overcomplication, though? Originally we only wanted to skip releases which were found in |
After all, |
I'm pretty sure the problem which Pom checking solves was primarily in in maven central |
Wasn't the bug about extractVersion and not custom registries? |
I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not what we want. This feature was designed for private registries, not maven central
Changes
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: