Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(platform/gitlab): consolidate duplicate code #32566

Merged
merged 9 commits into from
Nov 21, 2024

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Nov 15, 2024

Changes

  • Create a function out of the duplicate code from fetchPrList and getPr
  • Merge the logic of massagePr into util fn prInfo

Note: While the modification have caused changes to both code & tests (snaps to be accurate). Looking closely at the changes in snaps once can see that they are not result actual logical changes. But only trimming of unwanted fields present in the snaps. ie. they are not important to the test logic

Context

Reduce duplicate code and also use correct types.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice November 19, 2024 13:39
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@viceice viceice added this pull request to the merge queue Nov 21, 2024
Merged via the queue into renovatebot:main with commit 6bdd27a Nov 21, 2024
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

ssams pushed a commit to ssams/renovate that referenced this pull request Dec 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants