-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(platform/gitlab): consolidate duplicate code #32566
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
viceice
reviewed
Nov 18, 2024
viceice
reviewed
Nov 19, 2024
viceice
reviewed
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
viceice
approved these changes
Nov 21, 2024
🎉 This PR is included in version 39.25.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ssams
pushed a commit
to ssams/renovate
that referenced
this pull request
Dec 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fetchPrList
andgetPr
massagePr
into util fnprInfo
Note: While the modification have caused changes to both code & tests (snaps to be accurate). Looking closely at the changes in snaps once can see that they are not result actual logical changes. But only trimming of unwanted fields present in the snaps. ie. they are not important to the test logic
Context
Reduce duplicate code and also use correct types.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: