Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(versioning:regex): mention numeric capture group requirement #32777

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

mbrodala
Copy link
Contributor

@mbrodala mbrodala commented Nov 28, 2024

Changes

Context

See #13052 (reply in thread)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@mbrodala
Copy link
Contributor Author

mbrodala commented Nov 28, 2024

Notice that it probably makes sense to adjust the regex versioning to fail with an error in case parseInt() calls yield NaN. This way errors like this can be avoided. But that's a separate change.

@rarkins rarkins added this pull request to the merge queue Nov 28, 2024
Merged via the queue into renovatebot:main with commit 5cfc474 Nov 28, 2024
39 checks passed
@mbrodala mbrodala deleted the patch-2 branch November 28, 2024 09:45
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

ssams pushed a commit to ssams/renovate that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants