refactor: refactor Google Auth util #33486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbrunet
force-pushed
the
refactor/google-auth-util
branch
from
1d24f16 to
b2d5fe9
Compare
rarkins
approved these changes
Jan 8, 2025
|
🎉 This PR is included in version 39.98.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
getGoogleAuthTokenRawtogetGoogleAuthHostRuleand return aHostRulewith username/password instead of the token only to avoid repeating this credential pair in multiple placesContext
Follow up to:
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: