feat(velero): add support for mitm proxy #2170
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emosbaugh
changed the title
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
emosbaugh
force-pushed
the
emosbaugh/sc-123408/mount-ca-into-velero-containers
branch
from
2f650eb to
c514a36
Compare
emosbaugh
force-pushed
the
emosbaugh/sc-123408/mount-ca-into-velero-containers
branch
from
110a865 to
0bb2644
Compare
emosbaugh
commented
May 16, 2025
| "k8s.io/utils/ptr" | ||
| ) | ||
|
|
||
| // TODO: this should test creating a backup storage location and possibly a backup |
There was a problem hiding this comment.
I'm not sure this test adds much more value than the test here
pkg/addons/velero/integration/hostcabundle_test.go
There was a problem hiding this comment.
Agreed. To me it looks like they are testing the same things.
sgalsaleh
reviewed
May 16, 2025
pkg/addons/openebs/upgrade.go
Outdated
| @@ -27,13 +27,13 @@ func (o *OpenEBS) Upgrade(ctx context.Context, kcli client.Client, hcli helm.Cli | |||
| return errors.Wrap(err, "generate helm values") | |||
| } | |||
|
|
|||
| _, err = hcli.Upgrade(ctx, helm.UpgradeOptions{ | |||
| _, err = hcli.Upgrade(ctx, helm.InstallOptions{ | |||
JGAntunes
reviewed
May 20, 2025
| ) | ||
|
|
||
| t.Logf("%s: waiting for nodes to reboot", time.Now().Format(time.RFC3339)) | ||
| time.Sleep(30 * time.Second) |
There was a problem hiding this comment.
Is there a way that we can make this more robust by looping and test connecting to the node/checking the node status (and eventually timing out after a while)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a backup and restore test to proxy and mitm proxy e2e tests.
Before this change MITM proxy fails backup
https://github.com/replicatedhq/embedded-cluster/actions/runs/15061277910/job/42337183201?pr=2170
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?