Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rulesets): initial support repository rulesets (semi-dark release with the potential for breaking changes) #1029

Merged
merged 9 commits into from
Sep 17, 2024

Conversation

travi
Copy link
Member

@travi travi commented Sep 15, 2024

while still WIP for ergonomics, this is production ready, but with the potential for breaking changes before considered ready for full release. my plan is to release it semi-dark so that it can be used, but without highlighting it beyond the release notes or the specific docs page (which warns about the potential for breakages)

for #732

Copy link

vercel bot commented Sep 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2024 3:00pm

Comment on lines +3 to +8
> [!WARNING]
> Support for Repository Rulesets is still under development.
> Details may still change, like how the configuration is defined in the `settings.yml`.
> Please follow [#732](https://github.com/repository-settings/app/issues/732) for progress updates.
> Feedback is appreciated, but adopt cautiously, with the expectation of breaking changes until support is fully released.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while this should be fully functional with the current schema, it mirrors the github API expectations, which are somewhat cryptic for a non-programatic context. we prefer to mirror the github API most of the time, but i'm leaning away from that in this case

because of that, i want to release this progress in a semi-dark pre-release fashion. this warning is included in the docs to attempt to make that visible

@travi travi changed the title feat(rulesets): initial support repository rulesets (still WIP) feat(rulesets): initial support repository rulesets (semi-dark release with the potential for breaking changes) Sep 15, 2024
@travi travi merged commit 74919bf into master Sep 17, 2024
7 checks passed
@travi travi deleted the rulesets branch September 17, 2024 04:35
Copy link

🎉 This PR is included in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant