Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Test names have spaces #463

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HeathLoganCampbell
Copy link

@HeathLoganCampbell HeathLoganCampbell commented Feb 14, 2025

πŸ€” What's changed?

⚑️ What's your motivation?

Currently in Nunit3, all the test names are using the auto-generated function names that contain no spaces.
I want the spaces 😊

🏷️ What kind of change is this?

  • πŸ“– Documentation (improvements without changing code)
  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • πŸ› Bug fix (non-breaking change which fixes a defect)
  • ⚑ New feature (non-breaking change which adds new behaviour)
  • πŸ’₯ Breaking change (incompatible changes to the API)

♻️ Anything particular you want feedback on?

πŸ“‹ Checklist:

  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

Currently in Nunit3, all the test names are using the auto-generated function names that contain no spaces
@HeathLoganCampbell
Copy link
Author

HeathLoganCampbell commented Feb 14, 2025

I'm not really sure how I can go about testing this since I have only interacted with the NuGet version
OR if this would be better of just as a plugin ( But I have had some trouble with creating a plugin because it doesn't seem to run the code )

Would love any suggestions or help

@gasparnagy
Copy link
Contributor

I don't know either how this could be tested particularly (I will think on it), but two things you could do:

  1. Check the NUnit version where the setting was introduced (to see if it is compatible with the versions we support)
  2. Check if using this changes the possibilities of running scenarios filtered with vstest.console.exe (I remember having some problems with that.)

@304NotModified
Copy link
Contributor

304NotModified commented Feb 24, 2025

I'm not really sure how I can go about testing this since I have only interacted with the NuGet version

Maybe you could write unit tests? These examples could help: https://github.com/reqnroll/Reqnroll/blob/main/Tests/Reqnroll.GeneratorTests/UnitTestProvider/NUnit3GeneratorProviderTests.cs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants