v1.3.56 - Midi bindings crash

rerdavies · Oct 11, 2024 · 21f5c9e · 21f5c9e
1 parent 50fdd86
commit 21f5c9e
Show file tree

Hide file tree

Showing 9 changed files with 32 additions and 13 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1,10 +1,10 @@
 cmake_minimum_required(VERSION 3.16.0)
 project(pipedal 
-    VERSION 1.3.55
+    VERSION 1.3.56
     DESCRIPTION "PiPedal Guitar Effect Pedal For Raspberry Pi"
     HOMEPAGE_URL "https://rerdavies.github.io/pipedal"
 )
-set (DISPLAY_VERSION "PiPedal v1.3.55-Release")
+set (DISPLAY_VERSION "PiPedal v1.3.56-Release")
 set (PACKAGE_ARCHITECTURE "arm64")
 set (CMAKE_INSTALL_PREFIX "/usr/")
 

diff --git a/README.md b/README.md
@@ -6,13 +6,13 @@
 <a href="https://rerdavies.github.io/pipedal/LicensePiPedal.html"><img src="https://img.shields.io/badge/MIT-MIT?label=license&color=%23808080"/></a>
 <a href="https://github.com/rerdavies/pipedal/actions"><img src="https://img.shields.io/github/actions/workflow/status/rerdavies/pipedal/cmake.yml?branch=main"/></a>
 
-Download:&nbsp;<a href='https://rerdavies.github.io/pipedal/download.html'>v1.3.55</a> 
+Download:&nbsp;<a href='https://rerdavies.github.io/pipedal/download.html'>v1.3.56</a> 
 Website:&nbsp;[https://rerdavies.github.io/pipedal](https://rerdavies.github.io/pipedal).
 Documentation:&nbsp;[https://rerdavies.github.io/pipedal/Documentation.html](https://rerdavies.github.io/pipedal/Documentation.html).
 
 &nbsp;
 
-#### NEW version 1.3.55 Release, providing [snapshots](https://rerdavies.github.io/pipedal/Snaphots.html), and a new Performance View. See the [release notes](https://rerdavies.github.io/pipedal/ReleaseNotes) for details.
+#### NEW version 1.3.56 Release, providing [snapshots](https://rerdavies.github.io/pipedal/Snaphots.html), and a new Performance View. See the [release notes](https://rerdavies.github.io/pipedal/ReleaseNotes) for details.
 
 &nbsp;
 

diff --git a/docs/Installing.md b/docs/Installing.md
@@ -13,17 +13,17 @@ page_icon: img/Install4.jpg
 
 Download the most recent Debian (.deb) package for your platform:
 
-- [Raspberry Pi OS bookworm (64-bit) v1.3.55](https://github.com/rerdavies/pipedal/releases/download/)
+- [Raspberry Pi OS bookworm (64-bit) v1.3.56](https://github.com/rerdavies/pipedal/releases/download/)
 - [Ubuntu/Raspberry Pi OS bullseyeye (64-bit) v1.2.31](https://github.com/rerdavies/pipedal/releases/download/v1.1.31/pipedal_1.1.31_arm64.deb)
 
-Version 1.3.55 has not yet been tested on Ubuntu or Raspberry Pi OS bullseye. On these platforms, we recommend that you use version 1.1.31.
+Version 1.3.56 has not yet been tested on Ubuntu or Raspberry Pi OS bullseye. On these platforms, we recommend that you use version 1.1.31.
 
 Install the package by running 
 
 ```
   sudo apt update
   cd ~/Downloads  
-  sudo apt-get install pipedal_1.3.55_arm64.deb 
+  sudo apt-get install pipedal_1.3.56_arm64.deb 
 ```
 Adjust accordingly if you have downloaded v1.1.31.
 

diff --git a/docs/ReleaseNotes.md b/docs/ReleaseNotes.md
@@ -1,10 +1,11 @@
 # Release Notes
 
-## PiPedal 1.3.55 Release
+## PiPedal 1.3.56 Release
 
 More snapshot problems.
 
 Bug fixes:
+- MIDI bindings cause crash.
 - Crashes related to snapshots and split controls.
 - Loading/reloading/error screens go on top of Snapshot dialogs.
 

diff --git a/docs/download.md b/docs/download.md
@@ -4,15 +4,15 @@
 
 Download the most recent Debian (.deb) package for your platform:
 
-- <a href="https://github.com/rerdavies/pipedal/releases/download/v1.3.55/pipedal_1.3.55_arm64.deb">Raspberry Pi OS Bookworm (64-bit) v1.3.55</a>
+- <a href="https://github.com/rerdavies/pipedal/releases/download/v1.3.56/pipedal_1.3.56_arm64.deb">Raspberry Pi OS Bookworm (64-bit) v1.3.56</a>
 
 
 Install the package by running 
 
 ```
   sudo apt update
   cd ~/Downloads  
-  sudo apt-get install ./pipedal_1.3.55_arm64.deb
+  sudo apt-get install ./pipedal_1.3.56_arm64.deb
 ```
 
 Follow the instructions in [_Configuring PiPedal After Installation_](https://rerdavies.github.io/pipedal/Configuring.html) to complete the installation.
diff --git a/docs/index.md b/docs/index.md
@@ -1,15 +1,15 @@
 
 
 <img src="GithubBanner.png" width="100%"/>
-<a href="Installing.html"><i>v1.3.55</i></a>
+<a href="Installing.html"><i>v1.3.56</i></a>
 
 &nbsp;
 
 To download PiPedal, click [here](download.md). 
 To view PiPedal documentation, click [here](Documentation.md).
 
 
-#### NEW version 1.3.55 Release. See the [release notes](https://rerdavies.github.io/pipedal/ReleaseNotes) for details.
+#### NEW version 1.3.56 Release. See the [release notes](https://rerdavies.github.io/pipedal/ReleaseNotes) for details.
 
 &nbsp;
 

diff --git a/src/MidiBinding.hpp b/src/MidiBinding.hpp
@@ -73,6 +73,20 @@ class MidiBinding {
         result.symbol_ = symbol;
         return result;
     }
+    bool operator==(const MidiBinding&other) const
+    {
+        return this->symbol_ == other.symbol_
+        && this->channel_ == other.channel_
+        && this->bindingType_ == other.bindingType_
+        && this->note_ == other.note_ 
+        && this->control_ == other.control_
+        && this->minValue_ == other.minValue_
+        && this->maxValue_ == other.maxValue_
+        && this->rotaryScale_ == other.rotaryScale_
+        && this->linearControlType_ == other.linearControlType_
+        && this->switchControlType_ == other.switchControlType_;
+
+    }
     GETTER_SETTER(channel);
     GETTER_SETTER_REF(symbol);
     GETTER_SETTER(bindingType);

diff --git a/src/Pedalboard.cpp b/src/Pedalboard.cpp
@@ -327,6 +327,10 @@ bool PedalboardItem::IsStructurallyIdentical(const PedalboardItem&other) const
     {
         return false;
     }
+    if (this->midiBindings() != other.midiBindings())
+    {
+        return false;
+    }
     if (this->isSplit()) // so is the other by virtue of idential uris.
     {
         // provisionally, it seems ok to change the split type.

diff --git a/src/PiPedalModel.cpp b/src/PiPedalModel.cpp
@@ -1485,7 +1485,7 @@ void PiPedalModel::OnNotifyMidiValueChanged(int64_t instanceId, int portIndex, f
                             std::vector<IPiPedalModelSubscriber::ptr> t{subscribers.begin(), subscribers.end()};
                             for (auto &subscriber : t)
                             {
-                                t[i]->OnMidiValueChanged(instanceId, symbol, value);
+                                subscriber->OnMidiValueChanged(instanceId, symbol, value);
                             }
 
                             this->SetPresetChanged(-1, true);