Prevent mention form from hanging forever #1393
Conversation
ewan-escience
force-pushed
the
1384-fix-mention-form-no-title
branch
from
19a58d5 to
96295b6
Compare
| return crossrefItemToMentionItem(item) | ||
| try { | ||
| return crossrefItemToMentionItem(item) | ||
| } catch (e) { |
There was a problem hiding this comment.
Please remove e, it is unused
try{
...
} catch {
return null
}There was a problem hiding this comment.
What should I put instead? It has to have a name and ESLint also complains when I use _.
There was a problem hiding this comment.
What I mean change catch(e) to just catch because e is not used.
The rest of the code remains unchanged.
| export async function getUrlFromDoiOrg(doi: string) { | ||
| try { | ||
| const url = ` https://doi.org/api/handles/${encodeURIComponent(doi)}?type=URL` | ||
| const resp = await fetch(url) | ||
| // debugger | ||
| if (resp.status === 200) { | ||
| const json: DoiUrlResponse = await resp.json() | ||
| // extract | ||
| if (json.values.length > 0) { | ||
| const item = json.values[0] | ||
| if (item.type.toLowerCase() === 'url') { | ||
| return item.data.value | ||
| } | ||
| } | ||
| } | ||
| } catch (e: any) { | ||
| logger(`getUrlFromDoiOrg: ${e?.message}`, 'error') | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
You can also remove code from line 19-37 which is associated with this method
| @@ -59,8 +61,12 @@ export default function FindMentionSection({id,config,findPublicationByTitle}:Fi | |||
| const resp = await getMentionByDoi(searchFor) | |||
| if (resp?.status === 200) { | |||
| return [resp.message as MentionItemProps] | |||
| } else { | |||
| if (resp?.message) { | |||
| showErrorMessage(resp.message) | |||
There was a problem hiding this comment.
Maybe extend/combine error messages. Currently the message is about missing title.
I think it would be more clear to say: "Failed to import/process mention. \n{err.message}"
Something like that.
ewan-escience
force-pushed
the
1384-fix-mention-form-no-title
branch
from
96295b6 to
09d57b0
Compare
|
Prevent mention form from hanging forever
Changes proposed in this pull request
getUrlFromDoiOrgHow to test
docker compose down --volumes && docker compose build --parallel && docker compose up --scale data-generation=0https://doi.org/10.61686/GOLUA29851, this should result in an error message concerning its missing titleUnknown errorPart of #1384
PR Checklist:
docker-compose.yml