Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: organisation categories filter #1394

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmijatovic
Copy link
Contributor

@dmijatovic dmijatovic commented Feb 7, 2025

Custom categories filter for organisation

Changes proposed in this pull request:

  • Custom categories filter for organisation projects.
  • Custom categories filter for organisation software.
  • Category filter is not shown if categories are not defined in organisation settings.
  • Category filter is "dynamic" (as other filters); it shows only the categories "applied" by software/projects. If no category is used the category filter is empty (shows No options).
  • Category items in the filter are ordered by count, most used items are at the top of the list, then alphabetically.

How to test:

  • make start to build solution and generate test data
  • Login as rsd admin in order to be able to manipulate organisation categories
  • select one organisation from the list, one that has categories defined (see image 1)
  • navigate to organisation settings, categories.
  • Enable all categories to be for software. This can be defined at the root level by selecting the switch for software.
  • Navigate to software tab and confirm that Categories filter is shown. Note, the filter option can be empty if no software used any of the categories. If the filter is empty edit some of the software from the organisation list and add some categories. Confirm that selected categories are now shown in the category filter.
  • Now change all categories to be for project and perform same operations and checks as with software.
  • Next enable all categories to be for both software and project and confirm the filter is shown and works properly.
  • Finally disable all organisation categories for both software and projects in organisation settings and confirm that category filters are not shown.

Organisation categories (admin view)

image

Organisation software with categories filter

image

Organisation projects with categories filter

image

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

@dmijatovic dmijatovic force-pushed the 1350-organisation-categories-filter branch from 800a2f9 to 791a9ed Compare February 7, 2025 19:49
feat: project categories filter on organisation page
test: fix failing test - mock category hooks
feat: add for software/project message to the list item
@dmijatovic dmijatovic force-pushed the 1350-organisation-categories-filter branch from 791a9ed to 0ec2203 Compare February 10, 2025 10:10
Copy link

Copy link

Quality Gate Failed Quality Gate failed for 'rsd-frontend'

Failed conditions
10.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@dmijatovic dmijatovic marked this pull request as ready for review February 10, 2025 10:14
@dmijatovic dmijatovic mentioned this pull request Jan 6, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant