Skip to content

Fixes #244 #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixes #244 #247

wants to merge 3 commits into from

Conversation

barbich
Copy link

@barbich barbich commented Mar 28, 2024

refactor(cli/links): update ParseLinks method signatures to include base URL

aiven-amartin
aiven-amartin requested changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@aiven-amartin aiven-amartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! A motivational test/readme change should probably pair with this change.

Also I see you updating a bunch of imports to point to your fork. That is not something we would want to merge here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiven-amartin aiven-amartin aiven-amartin requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barbich @aiven-amartin