Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/zipwith] : implementing ZipWith functionnality and added a test #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nbtk123
Copy link

@nbtk123 nbtk123 commented Nov 17, 2022

Motivation

  • Added ZipWith functionality, e.g. taking elements from several upstreams in a round-robin fashion, bundling them to a single element, then sending it downstream.

Modifications

  • Implementation is in utils.go, the test is in flow_test.go.

Verify change

  • [V] Make sure the change passes the CI checks.

@reugn
Copy link
Owner

reugn commented Dec 8, 2022

Hi @nbtk123, thanks for your interest in the project.
I have a question related to the implementation of ZipWith. It will not work with finite streams where the number of elements is different. Also, what would be a real use case for this feature with possibly infinite streams? It does make sense to group elements by the key extracted by a selector function in a window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants