Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bad conflict solve #8

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Cristiandis
Copy link

@Cristiandis Cristiandis commented Nov 15, 2024

Fixes build issues, this time i tested it, my bad

Sources/Sideloading.x Outdated Show resolved Hide resolved
@oSumAtrIX
Copy link
Member

What exactly is the build issue?

@Cristiandis
Copy link
Author

What exactly is the build issue?

https://github.com/revenge-mod/revenge-tweak/actions/runs/11863132717

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Nov 16, 2024

Why did this occur https://github.com/revenge-mod/revenge-tweak/actions/runs/11863132717/job/33063956412#step:8:18
and how does the PR fix it? I am seeing big code blocks being removed but no explanation on why

@Cristiandis
Copy link
Author

Cristiandis commented Nov 16, 2024

Why did this occur https://github.com/revenge-mod/revenge-tweak/actions/runs/11863132717/job/33063956412#step:8:18

and how does the PR fix it? I am seeing big code blocks being removed but no explanation on why

i didn't fix conflicts correctly in the last pr so i had both the old and new version
i fixed here by looking and upstream and deleting the old part

@Cristiandis
Copy link
Author

this is the last upstream rebase i can do due to the licensing changes

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Nov 20, 2024

This PR should only make the changes that are necessary to fix the build issue. Other changes will be made with a separate PR

@Cristiandis
Copy link
Author

This PR should only make the changes that are necessary to fix the build issue. Other changes will be made with a separate PR

ok, will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants