Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bandit as defined-formats #129

Merged
merged 2 commits into from
Sep 17, 2023

Conversation

Alt-NoRock
Copy link
Member

defined bandit as defined-formats:

  • add bandit errorformat to python.go
  • add test-pattern
  • generated dog.go referenced by fmt/README.md

@Alt-NoRock
Copy link
Member Author

In locally test, I fixed #128 first.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This output is in a human-readable format.
It is better to use the custom formatter and pass it to errorformat.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I definitely agree that it's better to use custom formatter and output rdjson or use json formatter, I'm fine with including this change for handy use for now.

WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed format human-readable to the custom formatter in 72b569d

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I definitely agree that it's better to use custom formatter and output rdjson or use json formatter, I'm fine with including this change for handy use for now.

WDYT?

Copy link
Contributor

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem

defined bandit as defined-formats:
- add bandit errorformat to python.go
- add test-pattern
- generated dog.go referenced by fmt/README.md
@Alt-NoRock
Copy link
Member Author

Thank you for your comments.
According to your review, I will use custom formatter and output in the next PR.

And I rebased this branch to resolve conflict.

before defined format was in a human-readable format.
to use more structural format,  use bandit default custom format.
@Alt-NoRock
Copy link
Member Author

Sorry to late.
I changed defined format as your review.
Can you check this PR?

Copy link
Contributor

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shogo82148 shogo82148 merged commit 33358de into reviewdog:master Sep 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants