-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bandit as defined-formats #129
Conversation
In locally test, I fixed #128 first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This output is in a human-readable format.
It is better to use the custom formatter and pass it to errorformat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I definitely agree that it's better to use custom formatter and output rdjson or use json formatter, I'm fine with including this change for handy use for now.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed format human-readable to the custom formatter in 72b569d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I definitely agree that it's better to use custom formatter and output rdjson or use json formatter, I'm fine with including this change for handy use for now.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no problem
defined bandit as defined-formats: - add bandit errorformat to python.go - add test-pattern - generated dog.go referenced by fmt/README.md
de47d6a
to
6d84b08
Compare
Thank you for your comments. And I rebased this branch to resolve conflict. |
before defined format was in a human-readable format. to use more structural format, use bandit default custom format.
Sorry to late. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
defined bandit as defined-formats: