Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix partial arg match - close issue #125 #127

Merged
merged 2 commits into from
Mar 19, 2024
Merged

fix partial arg match - close issue #125 #127

merged 2 commits into from
Mar 19, 2024

Conversation

lgatto
Copy link
Member

@lgatto lgatto commented Mar 18, 2024

No description provided.

@lgatto lgatto requested a review from jorainer March 18, 2024 18:08
sgibb
sgibb approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@sgibb sgibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

R/rbindFill.R Outdated Show resolved Hide resolved
@lgatto @sgibb
Update R/rbindFill.R
f2c9deb 
Co-authored-by: Sebastian Gibb <[email protected]>
@lgatto
Copy link
Member Author

lgatto commented Mar 18, 2024

These warnings start to pop up since I set the following in my .Profile

options(warnPartialMatchArgs = TRUE,
        warnPartialMatchDollar = TRUE,
        warnPartialMatchAttr = TRUE)

jorainer
jorainer approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@jorainer jorainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! feel free to merge and push!

@lgatto lgatto merged commit 261e101 into main Mar 19, 2024
5 of 6 checks passed
@lgatto
Copy link
Member Author

lgatto commented Mar 19, 2024

Pushed to Bioc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorainer jorainer jorainer approved these changes

@sgibb sgibb sgibb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lgatto @sgibb @jorainer