Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't log a bogus warning when kickstart specifies a disk label
When this code was introduced back in c0c04cc , it used blivet 1.0 platform.setDefaultDiskLabelType, which checked whether the requested label was in the platform's supported labels, and returned False immediately if it wasn't. However, in mid-2017, blivet 2.0 made a big API change, and the equivalent method - `DiskLabel.set_default_label_type` - does not check the requested label in any way, and never returns anything. It just assumes whatever you passed is OK, sets it, and (implicitly) returns None. anaconda was updated to use the new method, but the "log a warning if it doesn't return" logic was left in place. So now we always log this warning. We do actually always set the label type, but the message is confusing. Signed-off-by: Adam Williamson <[email protected]>
- Loading branch information