Add support for bootupd to RHEL 9 #5424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poncovka
added
manual testing required
poncovka
force-pushed
the
rhel-9-bootupd
branch
from
bdba37b to
502c537
Compare
|
/build-image --boot-iso |
|
Images built based on commit 502c537:
Download the images from the bottom of the job status page. |
- Enable read only sysroot in the ostree repo config. - Add `rw` to the kernel arguments to keep statefull parts of the system (/var & /etc) writable. - Update units tests to account for the new rw karg (cherry-picked from a commit 0e00c90) Related: RHEL-2250
Some of the bootloader options are not needed until the installation. If we apply them during the scheduling of the partitions, it won't be possible to change them after that, for example, from an add-on. Let's apply these options later, right before the bootloader installation. (cherry-picked from a commit dbac59a) Related: RHEL-17205
Move the implementation to the `InstallBootloaderTask` class. (cherry-picked from a commit e96bded) Related: RHEL-17205
Add a new method for collecting kernel arguments for the installation. (cherry-picked from a commit 6967994) Related: RHEL-17205
Use the `CollectKernelArgumentsTask` task to collect kernel arguments for the installation. It will be used by the bootupd support that needs to be able to collect kernel arguments without installing the bootloader. (cherry-picked from a commit 8a7641e) Related: RHEL-17205
poncovka
force-pushed
the
rhel-9-bootupd
branch
from
502c537 to
c9f21cc
Compare
poncovka
removed
the
manual testing required
Original commit message from Colin Walters was: The https://github.com/coreos/bootupd project was created to fill the gap in bootloader management for ostree-based systems. When it was created, it was just integrated into Fedora CoreOS and derivatives; this left the Atomic Desktops (Silverblue etc.) as unfixed, and it was never used by RHEL for Edge. This PR is aiming to circle back and close that gap. We detect if bootupd is in the target root; if it is, then we skip the regular bootloader work, and just run bootupd to perform the installation. The other hacks we have around the grub config are no longer necessary in this mode. (cherry-picked from a commit 8e690d5) Resolves: RHEL-17205
(cherry-picked from a commit 0d42d2f) Related: RHEL-17205
This is an even newer behavior that takes over handling of the "UUID stamp files", which we want in general instead of using the static labels. Note `--write-uuid` implies `--with-static-configs`. This should fix this use case: ``` clearpart --all --initlabel --disklabel=gpt reqpart --add-boot part / --grow --fstype xfs ``` Whereas right now we require: ``` clearpart --all --initlabel --disklabel=gpt reqpart part /boot --size=1000 --fstype=ext4 --label=boot part / --grow --fstype xfs ``` Specifically the `--label=boot`. (cherry-picked from a commit 7b091de) Related: RHEL-17205
poncovka
force-pushed
the
rhel-9-bootupd
branch
from
c9f21cc to
a658b4b
Compare
VladimirSlavik
approved these changes
Jan 26, 2024
|
/kickstart-test --testtype smoke |
poncovka
added
the
ready to merge
rvykydal
added a commit
to rvykydal/kickstart-tests
that referenced
this pull request
Feb 6, 2024
Updates the test by enabling the bootloader for this change: rhinstaller/anaconda#5424
rvykydal
added a commit
to rvykydal/kickstart-tests
that referenced
this pull request
Feb 6, 2024
Updates the test by enabling the bootloader for this change: rhinstaller/anaconda#5424
jikortus
pushed a commit
to jikortus/kickstart-tests
that referenced
this pull request
Mar 21, 2024
Updates the test by enabling the bootloader for this change: rhinstaller/anaconda#5424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port the support for bootupd from #5350, #5342 and #5363.
Resolves: RHEL-17205
Depends on: #5427