Enable more ruff rules #6057
Open
Enable more ruff rules #6057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKoukiou
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
KKoukiou
force-pushed
the
enable-more-ruff-rules
branch
from
92c6c5c to
3cde489
Compare
KKoukiou
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
KKoukiou
force-pushed
the
enable-more-ruff-rules
branch
from
3cde489 to
dcd12bf
Compare
KKoukiou
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
KKoukiou
force-pushed
the
enable-more-ruff-rules
branch
from
dcd12bf to
6d89172
Compare
KKoukiou
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
/kickstart-tests --testtype smoke |
jkonecny12
requested changes
Dec 20, 2024
pyanaconda/ui/tui/hubs/__init__.py
Outdated
| prompt.add_option("1", _("to enter the %(spoke_title)s spoke") % {"spoke_title": list(self._spokes.values())[0].title}) | ||
| prompt.add_option( | ||
| "1", | ||
| _("to enter the %(spoke_title)s spoke") % {"spoke_title": next(iter(self._spokes.values())).title} |
There was a problem hiding this comment.
Honestly, this doesn't look like improvement. It's harder to read and understand.
There was a problem hiding this comment.
So keep this rule disabled ?
There was a problem hiding this comment.
I mean using next is fine but it's harder to understand. At least for me.
There was a problem hiding this comment.
Ok removed this commit.
Comment on lines
1284
to
1287
| # we're looking for the original vg name | ||
| idx = next((i for i, data in enumerate(self._containerStore) if data[0] == container_name), None) | ||
|
|
||
| for idx, data in enumerate(self._containerStore): | ||
| # we're looking for the original vg name | ||
| if data[0] == container_name: | ||
| break | ||
|
|
||
| if idx: | ||
| if idx is not None: |
There was a problem hiding this comment.
Again doesn't look to me like improvement.
There was a problem hiding this comment.
So keep this rule disabled ?
Or only this occurrence?
I dont have preference.
There was a problem hiding this comment.
Yes, that would be my personal preference.
There was a problem hiding this comment.
Ok removed this commit.
KKoukiou
force-pushed
the
enable-more-ruff-rules
branch
from
6d89172 to
e93def2
Compare
KKoukiou
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
* Replace 'dir' with 'directory' * Stop importing explicitely FileNotFound
Auto fix: * unnecessary-range-start (PIE808) * multiple-starts-ends-with (PIE810)
KKoukiou
force-pushed
the
enable-more-ruff-rules
branch
from
e93def2 to
5b6fb5a
Compare
KKoukiou
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.