Don't log a bogus warning when kickstart specifies a disk label #6085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this code was introduced back in c0c04cc , it used blivet 1.0 platform.setDefaultDiskLabelType, which checked whether the requested label was in the platform's supported labels, and returned False immediately if it wasn't. However, in mid-2017, blivet 2.0 made a big API change, and the equivalent method - `DiskLabel.set_default_label_type` - does not check the requested label in any way, and never returns anything. It just assumes whatever you passed is OK, sets it, and (implicitly) returns None. anaconda was updated to use the new method, but the "log a warning if it doesn't return" logic was left in place. So now we always log this warning. We do actually always set the label type, but the message is confusing. Signed-off-by: Adam Williamson <[email protected]>
AdamWill
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
jkonecny12
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Looks good to me. But I would like to know @vojtechtrefny opinion before merging.
|
/kickstart-test --testtype smoke |
vojtechtrefny
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this code was introduced back in c0c04cc , it used blivet 1.0 platform.setDefaultDiskLabelType, which checked whether the requested label was in the platform's supported labels, and returned False immediately if it wasn't.
However, in mid-2017, blivet 2.0 made a big API change, and the equivalent method -
DiskLabel.set_default_label_type- does not check the requested label in any way, and never returns anything. It just assumes whatever you passed is OK, sets it, and (implicitly) returns None.anaconda was updated to use the new method, but the "log a warning if it doesn't return" logic was left in place. So now we always log this warning. We do actually always set the label type, but the message is confusing.