Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edns pass config to system #6102

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Edns pass config to system #6102

merged 2 commits into from
Jan 27, 2025

Conversation

rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Jan 21, 2025 •
edited
Loading

@pep8speaks
Copy link

pep8speaks commented Jan 21, 2025 •
edited
Loading

Hello @rvykydal! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2025-01-27 08:59:26 UTC

@github-actions github-actions bot added the f42 Fedora 42 label Jan 21, 2025
@rvykydal
Copy link
Contributor Author

/kickstart-test --testtype smoke

@rvykydal
Copy link
Contributor Author

We should preserve also rd.net.dns-global-mode

@rvykydal rvykydal force-pushed the edns-pass-config-to-system branch from 550370b to a8df73f Compare January 22, 2025 15:28
@rvykydal rvykydal force-pushed the edns-pass-config-to-system branch from a8df73f to 2eae972 Compare January 22, 2025 15:31
@rvykydal
Copy link
Contributor Author

Kickstart test: rhinstaller/kickstart-tests#1361

@rvykydal
Copy link
Contributor Author

/kickstart-test --testtype smoke

@rvykydal rvykydal force-pushed the edns-pass-config-to-system branch from 2eae972 to 8df45b4 Compare January 27, 2025 08:59
@rvykydal
Copy link
Contributor Author

/kickstart-test --testtype smoke

@rvykydal rvykydal marked this pull request as ready for review January 27, 2025 13:04
jkonecny12
jkonecny12 approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rvykydal rvykydal merged commit e8de61a into rhinstaller:main Jan 27, 2025
18 of 19 checks passed
This was referenced Jan 30, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkonecny12 jkonecny12 jkonecny12 approved these changes

@jstodola jstodola Awaiting requested review from jstodola

Assignees
No one assigned
Labels
f42 Fedora 42
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rvykydal @pep8speaks @jkonecny12