Credentials file does not need to be mounted

rhiroe · Oct 2, 2024 · 12c249e · 12c249e
1 parent dc592a8
commit 12c249e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -24,7 +24,7 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: create dummy mount file
-        run: mkdir -p ~/.aws/config && touch ~/.aws/credentials && touch ~/.saml2aws
+        run: mkdir ~/.aws && touch ~/.aws/config && touch ~/.saml2aws
 
       - name: "Install latest devcontainer CLI"
         run: npm install -g @devcontainers/cli
@@ -44,7 +44,7 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: create dummy mount file
-        run: mkdir -p ~/.aws/config && touch ~/.aws/credentials && touch ~/.saml2aws
+        run: mkdir ~/.aws && touch ~/.aws/config && touch ~/.saml2aws
 
       - name: "Install latest devcontainer CLI"
         run: npm install -g @devcontainers/cli
@@ -59,7 +59,7 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: create dummy mount file
-        run: mkdir -p ~/.aws/config && touch ~/.aws/credentials && touch ~/.saml2aws
+        run: mkdir ~/.aws && touch ~/.aws/config && touch ~/.saml2aws
 
       - name: "Install latest devcontainer CLI"
         run: npm install -g @devcontainers/cli

diff --git a/src/ecspresso/devcontainer-feature.json b/src/ecspresso/devcontainer-feature.json
@@ -16,13 +16,6 @@
             "description": "Version of ecspresso to install."
         }
     },
-    "mounts": [
-        {
-            "source": "${localEnv:HOME}/.aws/credentials",
-            "target": "/root/.aws/credentials",
-            "type": "bind"
-        }
-    ],
     "installsAfter": [
         "ghcr.io/devcontainers/features/aws-cli"
     ]