Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Prepare for Version 0.6.0 #29

Merged
merged 51 commits into from
Apr 1, 2024
Merged

Feat: Prepare for Version 0.6.0 #29

merged 51 commits into from
Apr 1, 2024

Conversation

riandyrn
Copy link
Owner

@riandyrn riandyrn commented Mar 24, 2024

Changes Summary:

This PR is equivalent to otelmux v1.10.0.

As mentioned in #27, this PR covers go1.15 - 1.17. You can see that this PR has been tested on go1.15 - 1.17 here.

@riandyrn riandyrn mentioned this pull request Mar 24, 2024
@riandyrn riandyrn marked this pull request as ready for review March 24, 2024 09:30
Copy link
Collaborator

@ilhamsyahids ilhamsyahids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my below comment, can you add CHANGELOG.md to track changes other than in the PR description? So that it easier to track our changes instead of checking on the PR or release.

@riandyrn
Copy link
Owner Author

riandyrn commented Mar 25, 2024

Other than my below comment, can you add CHANGELOG.md to track changes other than in the PR description?

Hmm.., what is the difference with just accessing the releases page, @ilhamsyahids? 🤔

I mean, I check the CHANGELOG.md file for opentelemetry-go-contrib, and the content is basically the copy-paste of their releases page (see here).

To be honest, I currently don't see any additional value in doing this. But I might be wrong, and this is why I'm asking you this question.

@ilhamsyahids
Copy link
Collaborator

ilhamsyahids commented Mar 26, 2024

Hmm.., what is the difference with just accessing the releases page, @ilhamsyahids? 🤔

Here are what I'm thinking, @riandyrn:

  1. It easy to check in one-page other than through multiple page and no need to back and forth to the releases web page. Well, we can search from releases but sometimes give additional complexity other than search in the CHANGELOG.md from IDE (e.g. VSCode)
  2. Obviously track the changes, especially in unreleased version. We dont need to track when released time what has been changed in what PR. The things is not CHANGELOG.md is copy-paste from releases but releases is copy from CHANGELOG.md

@riandyrn
Copy link
Owner Author

riandyrn commented Mar 26, 2024

Ok, thanks for your suggestion regarding CHANGELOG.md, @ilhamsyahids.

I think for now, the PR description & release page are still enough for our use case.

Ok, after some careful consideration we decided to add CHANGELOG.md in #33.

ilhamsyahids and others added 17 commits March 29, 2024 11:04
Signed-off-by: Ilham Syahid S <[email protected]>
…his is to ensure we have the same supported compatibilities as OpenTelemetry Go.
…on to version.go to follow OpenTelemetry Go convention;
Signed-off-by: Ilham Syahid S <[email protected]>
@riandyrn riandyrn marked this pull request as draft March 31, 2024 21:07
@riandyrn riandyrn marked this pull request as ready for review April 1, 2024 05:29
@riandyrn riandyrn merged commit 97ac2b9 into master Apr 1, 2024
1 check passed
@riandyrn riandyrn deleted the feat/version-0.6 branch April 1, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty status code in span when handler is not sending data
3 participants