Skip to content

Commit

Permalink
Remove Requires
Browse files Browse the repository at this point in the history
  • Loading branch information
ricaun committed Dec 12, 2024
1 parent 4677cbf commit adc41a1
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 8 deletions.
7 changes: 4 additions & 3 deletions Build/IAzureSignTool.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,15 @@ public interface IAzureSignTool : IClean, ICompile
.Before(Compile)
//.Requires<NuGetKeyVaultSignToolTasks>()
//.Requires<AzureSignToolTasks>()
.Requires<GitVersionTasks>()
.Requires<NuGetTasks>()
//.Requires<GitVersionTasks>()
//.Requires<NuGetTasks>()
.Executes(() =>
{
ricaun.Nuke.Tools.AzureSignToolUtils.EnsureAzureToolIsInstalled();

Serilog.Log.Information(AzureSignToolTasks.AzureSignToolPath);
Serilog.Log.Information(NuGetKeyVaultSignToolTasks.NuGetKeyVaultSignToolPath);

//ricaun.Nuke.Tools.AzureSignToolUtils.DownloadAzureSignTool();
//Serilog.Log.Information("DownloadAzureSignTool");
//ricaun.Nuke.Tools.AzureSignToolUtils.DownloadNuGetKeyVaultSignTool();
//Serilog.Log.Information("DownloadNuGetKeyVaultSignTool");
Expand Down
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Enable sign files using `Azure Key Vault`.
### Build
- Add `IAzureSignTool` to check if `AzureSignToolUtils` is installed.
- Update `IAzureSignTool` with `Requires`.
- [ ] Update `IAzureSignTool` with `Requires`.
- [ ] Add import `build` with `.targets`
### Updates
- Add `AzureSignToolUtils` to sign files using `AzureSignToolTasks` or `NuGetKeyVaultSignToolTasks`.
Expand All @@ -18,7 +18,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- [ ] Add `build` with `.targets` to install packages `AzureSignTool` and `NuGetKeyVaultSignTool`.
- Add `PackageDownload` to download `AzureSignTool` and `NuGetKeyVaultSignTool` on the fly.
- Update `IClear` with `CreateTemporaryIgnore`.
- Update `ISign` with `Requires`.
- [ ] Update `ISign` with `Requires`.
- Add `HttpAuthTasks` to get/post files.
### Tests
- Update `NuGetExtensionTests`
Expand Down
4 changes: 2 additions & 2 deletions ricaun.Nuke/Components/ISign.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ public interface ISign : ICompile, IHazSign, IHazSolution, INukeBuild
/// </summary>
Target Sign => _ => _
.TriggeredBy(Compile)
.Requires<NuGetKeyVaultSignToolTasks>()
.Requires<AzureSignToolTasks>()
//.Requires<NuGetKeyVaultSignToolTasks>()
//.Requires<AzureSignToolTasks>()
.Executes(() =>
{
SignProject(MainProject);
Expand Down
2 changes: 1 addition & 1 deletion ricaun.Nuke/ricaun.Nuke.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

<PropertyGroup>
<PackageId>ricaun.Nuke</PackageId>
<Version>1.9.0-alpha.7</Version>
<Version>1.9.0-alpha.8</Version>
</PropertyGroup>

<PropertyGroup>
Expand Down

0 comments on commit adc41a1

Please sign in to comment.