Skip to content

Commit

Permalink
Update and remove Obsolete
Browse files Browse the repository at this point in the history
  • Loading branch information
ricaun committed Jul 28, 2024
1 parent 1670472 commit f85c082
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 20 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Add `RibbonThemePanelUtils` to update the theme for itens in the `RibbonPanel`.
- Update `RibbonPanel` create and remove to update the theme of the itens.
- Update `TryThemeImage` to not change assembly name if is a resource component.
- Remove `ConsoleAttribute` and `SetOrderPanels` obsolete methods.
- Update `GetAutodeskOwner` to obsolete only in `net46`.
### Tests
- Add `RibbonThemeUtilsTests` to test the theme change event.
- Add `TryThemeImage` tests to replace image with theme.
Expand Down
2 changes: 1 addition & 1 deletion Directory.Build.props
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Project>
<PropertyGroup>
<Version>0.7.0-rc.1</Version>
<Version>0.7.0-rc.2</Version>
</PropertyGroup>
</Project>
8 changes: 0 additions & 8 deletions ricaun.Revit.UI/AppLoaderAttribute.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,6 @@

namespace ricaun.Revit.UI
{
/// <summary>
/// Console Attribute for ricaun.AppLoader
/// </summary>
[Obsolete("This method gonna be removed, use AppLoaderAttribute")]
public class ConsoleAttribute : Attribute
{
}

/// <summary>
/// AppLoader Attribute for ricaun.AppLoader
/// </summary>
Expand Down
4 changes: 3 additions & 1 deletion ricaun.Revit.UI/AutodeskExtension.cs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ public static void SetAutodeskOwner(this Window window)
/// Get Autodesk.Windows as the Owner Window
/// </summary>
/// <returns></returns>
[Obsolete("This funciton does not work with Revit 2018 and 2017, gonna be removed.")]
#if NET46
[Obsolete("This funciton does not work with Revit 2018 and 2017, Revit Application is not a Window.")]
#endif
public static Window GetAutodeskOwner()
{
var owner = ComponentManager.ApplicationWindow;
Expand Down
10 changes: 0 additions & 10 deletions ricaun.Revit.UI/RibbonTabExtension.cs
Original file line number Diff line number Diff line change
Expand Up @@ -111,16 +111,6 @@ public static Autodesk.Windows.RibbonTab SetPanelsOrderByTitle(this Autodesk.Win
return ribbonTab.SetPanelsOrderBy(ComparationOrderByTitle);
}

/// <summary>
/// Set Order of Panels by Title
/// </summary>
/// <param name="ribbonTab"></param>
[Obsolete("This method gonna be removed, use SetPanelsOrderByTitle")]
public static void SetOrderPanels(this Autodesk.Windows.RibbonTab ribbonTab)
{
ribbonTab.SetPanelsOrderByTitle();
}

private static string ComparationOrderByTitle(Autodesk.Windows.RibbonPanel ribbonPanel)
{
return ribbonPanel.Source.Title;
Expand Down

0 comments on commit f85c082

Please sign in to comment.