Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target/riscv: use buf_get_uXX instead of manual bit shift #1173

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

fk-sc
Copy link
Contributor

@fk-sc fk-sc commented Nov 22, 2024

Replaced manual bit shift with buf_get_u64/buf_get_u32

en-sc
en-sc previously approved these changes Nov 25, 2024
Copy link
Collaborator

@en-sc en-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (reviewed internally).

@aap-sc
Copy link
Collaborator

aap-sc commented Nov 26, 2024

@JanMatCodasip would you kindly take a look too?

JanMatCodasip
JanMatCodasip previously approved these changes Nov 28, 2024
Copy link
Collaborator

@JanMatCodasip JanMatCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

src/target/riscv/riscv-013.c Show resolved Hide resolved
src/target/riscv/riscv-013.c Show resolved Hide resolved
src/target/riscv/riscv-013.c Show resolved Hide resolved
@fk-sc fk-sc dismissed stale reviews from JanMatCodasip and en-sc via 22bed8a November 29, 2024 15:27
@fk-sc fk-sc force-pushed the buf-get branch 3 times, most recently from 9079617 to af151d7 Compare November 29, 2024 22:04
@fk-sc fk-sc requested a review from JanMatCodasip December 1, 2024 13:05
JanMatCodasip
JanMatCodasip previously approved these changes Dec 3, 2024
Replaced manual bit shift with buf_get_u64/buf_get_u32

Signed-off-by: Farid Khaydari <[email protected]>
@en-sc en-sc merged commit ea8f9d5 into riscv-collab:riscv Dec 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants