Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Run the "snapshot" action only on the main branch #1229

Open
wants to merge 1 commit into
base: riscv
Choose a base branch
from

Conversation

JanMatCodasip
Copy link
Collaborator

Make sure that the "snapshot" action only runs when pushing changes to the main branch - "riscv". No need to run it for individual commits under side-branches.

Change-Id: I5877a3b5635fc6053af7718e38a4d5a093e02744

Make sure that the "snapshot" action only runs when pushing changes
to the main branch - "riscv". No need to run it for individual
commits under side-branches.

Change-Id: I5877a3b5635fc6053af7718e38a4d5a093e02744
Signed-off-by: Jan Matyas <[email protected]>
@JanMatCodasip
Copy link
Collaborator Author

JanMatCodasip commented Feb 14, 2025

Note: This patch only prevents the "snapshot" workflow from getting executed on commits within a feature branch (as happened e.g. here).

The "snapshot" workflow itself appears broken at the moment, and will require an update - the jimtcl dependency will probably need to be built from source in the cross-build.sh script.

EDIT: I can see the update of cross-build.sh has already been submitted in https://review.openocd.org/c/openocd/+/8751.

@sobuch
Copy link
Contributor

sobuch commented Feb 17, 2025

I like this change, the snapshot action is more of a "release" than a "test" job anyway, no need to run on every branch pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants