Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector Status flag mstatus[VS] is not updated correctly #569

Open
Timmmm opened this issue Oct 2, 2024 · 0 comments · May be fixed by #623
Open

Vector Status flag mstatus[VS] is not updated correctly #569

Timmmm opened this issue Oct 2, 2024 · 0 comments · May be fixed by #623
Labels
bug Something isn't working good first issue Good for newcomers vector Issues related to the Vector extension

Comments

@Timmmm
Copy link
Collaborator

Timmmm commented Oct 2, 2024

The spec says:

The VS field encodes the status of the vector extension state, including the vector registers v0–v31 and the CSRs vcsr, vxrm, vxsat, vstart, vl, vtype, and vlenb.

However currently VS is only dirtied when you write to vcsr. I think a call to dirty_v_context_if_present() is missing for most of the other CSRs.

Also I'm not sure about dirty_v_context_if_present() since it seem to be checking whether vector is supported which is always the case if we're modifying those CSRs so it's at best redundant, and at worst should it check misa[V] instead of sys_enable_vext()?

@Timmmm Timmmm added vector Issues related to the Vector extension bug Something isn't working good first issue Good for newcomers labels Oct 2, 2024
@rez5427 rez5427 linked a pull request Nov 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers vector Issues related to the Vector extension
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant