Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump deps #437

Merged
merged 1 commit into from
Nov 27, 2024
Merged

build: bump deps #437

merged 1 commit into from
Nov 27, 2024

Conversation

hai-rise
Copy link
Contributor

No description provided.

@hai-rise hai-rise requested a review from kien-rise November 27, 2024 06:08
Copy link
Contributor

@i1i1 i1i1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, WDUT of adding dependabot to repo. It can bump most of the dependencies (probably apart from alloy/reth and our git dependencies 🤔

https://docs.github.com/en/code-security/dependabot/dependabot-version-updates

@hai-rise
Copy link
Contributor Author

Btw, WDUT of adding dependabot to repo. It can bump most of the dependencies (probably apart from alloy/reth and our git dependencies 🤔

https://docs.github.com/en/code-security/dependabot/dependabot-version-updates

I hate dependabot with a passion. Our crates are very sensitive to dependencies (both correctness and performance) so I'd prefer to bump most at once for a careful test & bench. Alloy is breaking API often so cargo update can easily fail to build. We also only need this every few weeks so no need to automate yet.

Copy link
Contributor

@kien-rise kien-rise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested with a few of blocks on Optimism Mainnet.
Note that new blocks after Granite are failing.

Granite    approved    Wed Sep 11 16:00:01 UTC 2024 (1726070401) around block 125235812

@hai-rise
Copy link
Contributor Author

hai-rise commented Nov 27, 2024

@i1i1 In all seriousness, things like dependabot will be helpful once we have #351 and #388 in place to automate the testing of each (granular) dependency bump. Until then, we can manually do it every few weeks, all dependencies together :).

@hai-rise hai-rise merged commit b71b01f into main Nov 27, 2024
2 checks passed
@hai-rise hai-rise deleted the bump-deps branch November 27, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants