Skip to content

Commit

Permalink
make decodeFont and decodeAudio non virtual
Browse files Browse the repository at this point in the history
This was causing the Lambda recorder builds to fail as these methods weren't linking properly because they were never overridden (super strange seems like a compiler or linker bug). We don't need these to be virtual as the logic for returning the correct concrete object is always known at compile time.

```
Linking rive_thumbnail_generator
/usr/bin/ld:../../renderer/build/linux/bin/release/librive_skia_renderer.a(skia_factory.o):(.data.rel.ro+0x190): undefined reference to `rive::Factory::decodeFont(rive::Span<unsigned char const>)'
/usr/bin/ld:../../renderer/build/linux/bin/release/librive_skia_renderer.a(skia_factory.o):(.data.rel.ro+0x198): undefined reference to `rive::Factory::decodeAudio(rive::Span<unsigned char const>)'
clang: error:linker command failed with exit code 1 (use -v to see invocation)
```

Diffs=
aee913977a make decodeFont and decodeAudio non virtual (#9025)

Co-authored-by: Luigi Rosso <[email protected]>
  • Loading branch information
luigi-rosso and luigi-rosso committed Feb 12, 2025
1 parent 33d561d commit ce1d6a1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .rive_head
Original file line number Diff line number Diff line change
@@ -1 +1 @@
e816b03089efc637b6161d55e8a1543d07bdbae9
aee913977a8ffb8dd7df5bf5eb2951f02344eb48
4 changes: 2 additions & 2 deletions include/rive/factory.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@ class Factory

virtual rcp<RenderImage> decodeImage(Span<const uint8_t>) = 0;

virtual rcp<Font> decodeFont(Span<const uint8_t>);
rcp<Font> decodeFont(Span<const uint8_t>);

virtual rcp<AudioSource> decodeAudio(Span<const uint8_t>);
rcp<AudioSource> decodeAudio(Span<const uint8_t>);

// Non-virtual helpers

Expand Down

0 comments on commit ce1d6a1

Please sign in to comment.