Fix Yoga crash with percent margin

When a layout is set to use percent margins at the same time that that layout node can't be computed due to a combination of hug/fill layouts, Yoga asserts with:

"availableWidth is indefinite so widthMeasureMode must be YGMeasureModeUndefined"
or
"availableHeight is indefinite so heightMeasureMode must be YGMeasureModeUndefined"

This crash only occurs with percent margins, not padding. At this point its unclear whether this is a bug in Yoga but this PR mitigates the crash.

Diffs=
339867b4de Fix Yoga crash with percent margin (#9010)

Co-authored-by: Philip Chung <[email protected]>

.rive_head

@@ -1 +1 @@
-7968fd06b819e702e1a6fea94221e93e356c889a
+339867b4de68e3c301409dad079747b954d4fa11

include/rive/layout_component.hpp

@@ -274,6 +274,8 @@ class LayoutComponent : public LayoutComponentBase,
     void scaleTypeChanged();
     void displayChanged();
     void flexDirectionChanged();
+    bool willComputeValidWidth();
+    bool willComputeValidHeight();
 #endif
     void buildDependencies() override;
 

src/layout_component.cpp

@@ -252,6 +252,57 @@ StatusCode LayoutComponent::onAddedClean(CoreContext* context)
     return StatusCode::Ok;
 }
 
+bool LayoutComponent::willComputeValidWidth()
+{
+    auto p = parent();
+    while (p != nullptr)
+    {
+        if (p->is<LayoutComponent>() && !p->is<Artboard>())
+        {
+            auto layout = p->as<LayoutComponent>();
+            if (layout->style() != nullptr)
+            {
+                if (layout->style()->widthScaleType() == LayoutScaleType::fixed)
+                {
+                    return true;
+                }
+                if (layout->style()->positionType() == YGPositionTypeAbsolute)
+                {
+                    break;
+                }
+            }
+        }
+        p = p->parent();
+    }
+    return false;
+}
+
+bool LayoutComponent::willComputeValidHeight()
+{
+    auto p = parent();
+    while (p != nullptr)
+    {
+        if (p->is<LayoutComponent>() && !p->is<Artboard>())
+        {
+            auto layout = p->as<LayoutComponent>();
+            if (layout->style() != nullptr)
+            {
+                if (layout->style()->heightScaleType() ==
+                    LayoutScaleType::fixed)
+                {
+                    return true;
+                }
+                if (layout->style()->positionType() == YGPositionTypeAbsolute)
+                {
+                    break;
+                }
+            }
+        }
+        p = p->parent();
+    }
+    return false;
+}
+
 void LayoutComponent::drawProxy(Renderer* renderer)
 {
     if (clip())
@@ -704,14 +755,32 @@ void LayoutComponent::syncStyle()
         YGValue{m_style->borderTop(), m_style->borderTopUnits()};
     ygStyle.border()[YGEdgeBottom] =
         YGValue{m_style->borderBottom(), m_style->borderBottomUnits()};
+
+    auto hasValidWidth = willComputeValidWidth();
+    auto hasValidHeight = willComputeValidHeight();
+    auto marginLeftUnits =
+        !hasValidWidth && m_style->marginLeftUnits() == YGUnitPercent
+            ? YGUnitAuto
+            : m_style->marginLeftUnits();
+    auto marginRightUnits =
+        !hasValidWidth && m_style->marginRightUnits() == YGUnitPercent
+            ? YGUnitAuto
+            : m_style->marginRightUnits();
+    auto marginTopUnits =
+        !hasValidHeight && m_style->marginTopUnits() == YGUnitPercent
+            ? YGUnitAuto
+            : m_style->marginTopUnits();
+    auto marginBottomUnits =
+        !hasValidHeight && m_style->marginBottomUnits() == YGUnitPercent
+            ? YGUnitAuto
+            : m_style->marginBottomUnits();
     ygStyle.margin()[YGEdgeLeft] =
-        YGValue{m_style->marginLeft(), m_style->marginLeftUnits()};
+        YGValue{m_style->marginLeft(), marginLeftUnits};
     ygStyle.margin()[YGEdgeRight] =
-        YGValue{m_style->marginRight(), m_style->marginRightUnits()};
-    ygStyle.margin()[YGEdgeTop] =
-        YGValue{m_style->marginTop(), m_style->marginTopUnits()};
+        YGValue{m_style->marginRight(), marginRightUnits};
+    ygStyle.margin()[YGEdgeTop] = YGValue{m_style->marginTop(), marginTopUnits};
     ygStyle.margin()[YGEdgeBottom] =
-        YGValue{m_style->marginBottom(), m_style->marginBottomUnits()};
+        YGValue{m_style->marginBottom(), marginBottomUnits};
     ygStyle.padding()[YGEdgeLeft] =
         YGValue{m_style->paddingLeft(), m_style->paddingLeftUnits()};
     ygStyle.padding()[YGEdgeRight] =