Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lastConsumed and lastDeficit for slurm remote license #109

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

kbroch-rivosinc
Copy link
Contributor

@kbroch-rivosinc kbroch-rivosinc commented Dec 14, 2024

resolves #108

Copy link
Collaborator

@abhinavDhulipala abhinavDhulipala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the following fixture file with representative values and fix the corresponding test to emit 5 metrics per licenser poll.

You can find the missing test with: go test ./exporter -short

Otherwise, great work!

@kbroch-rivosinc kbroch-rivosinc force-pushed the dev/kbroch/add-lastupdate-lastdeficit branch from 2ec6640 to 349d34e Compare December 16, 2024 18:46
@kbroch-rivosinc kbroch-rivosinc force-pushed the dev/kbroch/add-lastupdate-lastdeficit branch from 349d34e to cbcddb1 Compare December 16, 2024 18:50
@kbroch-rivosinc
Copy link
Contributor Author

Please update the following fixture file with representative values and fix the corresponding test to emit 5 metrics per licenser poll.

You can find the missing test with: go test ./exporter -short

Otherwise, great work!

made the changes and ran:

~/work/prometheus-slurm-exporter on dev/kbroch/a…-lastdeficit:main ⇡1                                         at 10:54:12 AM
❯ go test ./exporter -short
ok      github.com/rivosinc/prometheus-slurm-exporter/exporter  0.310s

Copy link
Collaborator

@abhinavDhulipala abhinavDhulipala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@abhinavDhulipala abhinavDhulipala merged commit 941a626 into main Dec 16, 2024
4 checks passed
@abhinavDhulipala abhinavDhulipala deleted the dev/kbroch/add-lastupdate-lastdeficit branch December 16, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add LastConsumed and LastDeficit measurements for Slurm remote license resources
2 participants