Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[squeue] fix NONE time cli-fallback bug #27

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

abhinavDhulipala
Copy link
Collaborator

slurm 22.x can emmit NONE null vals on cmd line. Although we don't guarantee backward compatibility, this doesn't cost us anything to support. Bugs is red-green tested off-course. We might experience this same problem for NAbleFloats, but I'll wait for someone to file a bug against that before implementing it.

resolves #26

@abhinavDhulipala
Copy link
Collaborator Author

@jmcastelo I'll merge this once you confirm that this branch solves your problem. It took no effort to support. If you have a different idea in mind, feel free to open a separate PR

@abhinavDhulipala abhinavDhulipala self-assigned this Nov 1, 2023
@abhinavDhulipala abhinavDhulipala merged commit 288c23e into main Nov 1, 2023
4 checks passed
@abhinavDhulipala abhinavDhulipala deleted the NAble-time-nullvalue branch November 3, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cli-fallback] squeue 22.04 NAbleTime Unmarshall error
1 participant