-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create binaries on each release #92
Conversation
We might also want to consider making this action dependent on the testing stage of our pipeline. All though it could also be argued that it is safe to assume the code at the tag would be working, I would still put the clause in just to be sure. Our pre-commit and tests are fast anyway. |
Annoyingly making it dependent on the testing stage of the pipeline looks difficult - because you can do it, but then it will run every time the verify/testing action runs - and we don't want to be building binaries for every commit, I think? https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflow_run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I'll create a new micro release in the next couple days to test this out.
This pull request adds functionality, using 'goreleaser', to build binaries on each release.
resolves #86