Vbf datacards systs tt exploration #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merging these branches together so that we can produce vbf_templates and datacards in a single branch.
…n to study strange TT background in vbf search
…n to study strange TT background in vbf search
rkansal47
reviewed
Nov 11, 2023
| @@ -452,7 +454,7 @@ def process(self, events: ak.Array): | |||
| msds = jmsr_shifted_vars["msoftdrop"][shift] | |||
| pnetms = jmsr_shifted_vars["particleNet_mass"][shift] | |||
|
|
|||
| if self._save_all: | |||
| if self._save_all & False: | |||
| @@ -634,6 +636,14 @@ def process(self, events: ak.Array): | |||
|
|
|||
| # TODO: need to be careful about the sum of gen weights used for the LHE/QCDScale uncertainties | |||
| logger.debug("weights ", weights._weights.keys()) | |||
|
|
|||
| # TEMP: save each individual weight | |||
| skimmed_events["L1EcalPrefiring"] = ak.to_numpy(events.L1PreFiringWeight.Nom) | |||
There was a problem hiding this comment.
Will this not be saved from the "single_weight" for loop below?
| skimmed_events["L1EcalPrefiring"] = ak.to_numpy(events.L1PreFiringWeight.Nom) | ||
|
|
||
| for key in weights._weights.keys(): | ||
| print(f"single_weight_{key}") |
There was a problem hiding this comment.
I think the print() can be removed here.
| @@ -1014,7 +1024,7 @@ def getVBFVars( | |||
| # int list representing the number of passing vbf jets per event | |||
| vbfVars[f"nGoodVBFJets"] = n_good_vbf_jets_sorted_pt.to_numpy() | |||
|
|
|||
| adding_bdt_vars = True | |||
| adding_bdt_vars = False | |||
There was a problem hiding this comment.
I changed this to false - can you confirm that we don't need these in the processor since they can be added in postprocessing?
| @@ -387,6 +387,8 @@ def process(self, events: ak.Array): | |||
| ) | |||
|
|
|||
| skimmed_events["nGoodVBFJets"] = np.array(ak.sum(vbf_jet_mask, axis=1)) | |||
| # Temp | |||
| skimmed_events["gen_weights"] = gen_weights | |||
There was a problem hiding this comment.
Will this not be saved from the "single_weight" for loop below?
There was a problem hiding this comment.
I think this branch has a lot of bad "quick fixes" for saving the weight information which should not be kept otherwise. So would we just erase the pull request?
Yea, that part is redundant I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edits to bbVVSkimmer where we keep pileup weights (has the vbf postprocessing edits in there too. (built off of that))