-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: bzlmod lock file #96
Open
manuelnaranjo
wants to merge
20
commits into
rmohr:main
Choose a base branch
from
bookingcom:mnaranjo/bzlmod-lock-file
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducing a command capable of generating a list of locked packages from a set of targets and excluded packages
Now we can pass dependencies between the rpmtree instances.
Adding to the lockfile the parameters of how it got called so it can be used to run a pin process again.
Now we can use the lock file to make bazel aware of RPMs through bzlmod
Now there's a helper in the proxy repo to pin dependencies again
Reducing the size of the lock file by relying on repositories, mirrors and href
The format for the lock file is not yet determined
Sometimes you want to embed the bazeldnf binary into some other rule, and for this you don't want to create rules and mess with toolchains, instead adding a target that symlinks the target properly
Allow me to run by using the shell file in the bazel-bin directory
* Ignore recursive dependencies in RPMs because why not, RPMs are a mess * Introduce artifacts for lock file which allows us on the MODULE.bazel to show the dependency tree.
Testing bzlmod CI to test the integration
When using the lockfile don't put the prefix in the alias repository
the bash script should be easier to relocate and call from ./bazel-bin without a `bazel run`
Pass CLI arguments to bzlmod when called through bazel run or others
exposing nobest in the bzlmod lock file, same as we have in the other commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBD