Merge v2.6-alpha (bigbluebutton#1672)

* GRN2-xx: Switch the relation between users and roles to make queries cleaner and faster (bigbluebutton#1299)

* First steps

* Fixes in account creation flow

* Fixed most testcases

* more test fixes

* Fixed more test cases

* Passing tests and rubocop

* Added rake task to remove rooms

* Adding translation (bigbluebutton#1510)

* Update _account.html.erb

* Update en.yml

* Fix "for" attribute for label elements (bigbluebutton#1488)

Co-authored-by: Ahmad Farhat <[email protected]>

* Fix some issues reported by LGTM (bigbluebutton#1478)

* Declare local JavaScript variables (reported by LGTM)

Signed-off-by: Stefan Weil <[email protected]>

* Remove unused local JavaScript variable (reported by LGTM)

Signed-off-by: Stefan Weil <[email protected]>

* Puma Worker Configuration (bigbluebutton#1332)

We noticed that the current default settings perform very poorly under
load. We managed to literally take down Greenlight during a larger event
when people where accessing the landing page for rooms and when doing
some tests, I was more or less able to DoS Greenlight on my own.

This patch adds a default worker configuration which significantly
improves the situation. The small, 4 core machine I was testing on could
handle about thrice the amount of requests.

While the new default configuration should be reasonably well suited for
most deployments, this patch further allows users to easily configure
the worker pool on their own in the environment file.

* Made name and email readonly for no greenlight accounts (bigbluebutton#1534)

* Fixed hardcoded string (bigbluebutton#1532)

* fixed spelling error that was bugging me :) - sep a rat e (bigbluebutton#1535)

Co-authored-by: Dave Lane <[email protected]>

* Improve Server Rooms View (bigbluebutton#1524)

* Order rooms by status

* Cleaned up order function

* Now displays Started/Created/Ended

* Added participant count to rooms list

* Fix rake task user:create so that users can be created when terms are present (bigbluebutton#1565)

* Changed user create task to always accept terms

* clean up

* More secure room ID (bigbluebutton#1451)

* Legal and privpolicy link (bigbluebutton#1421)

* add customizable Links to Imprint and Privacy Policy

* fix copy&paste error in spec

* replace "imprint" with "legal" since that is the correct term

* remove german translation of new strings, transifex will take care of them later

* GRN2-295:Refactored update profile and update password (bigbluebutton#1591)

* Refactored update profile and update password

* Relowered rubocop settings

* Fixed email sending when not supposed to (bigbluebutton#1592)

* Design changes for small screens  (bigbluebutton#1580)

* now rap for pagination

* Update _subtitle.html.erb

* Update _rooms.html.erb

* Update _recordings.html.erb

* Update _rooms.html.erb

* Update _users.html.erb

* Update cant_create_rooms.html.erb

* Update room.js

* Update edit.html.erb

* Update new.html.erb

* Update cant_create_rooms.html.erb

* Update _sessions.html.erb

* Update _account.html.erb

* Make Greenlight work with Ruby 2.7 (bigbluebutton#1560)

Greenlight's failure to start up with Ruby 2.7 seems to be caused by [an
issue in bootsnap](Shopify/bootsnap#258).
Updating that library makes Greenlight work again.

However, there are still a lot of deprecation warnings. But that's
something to deal with separately.

This fixes bigbluebutton#1558

* use email input for sign in (bigbluebutton#1199)

* use email input for sign in

* use email input for registration

* use email input for invitation

* use email input for account settings

Co-authored-by: Ahmad Farhat <[email protected]>

* Fix Gemfile (bigbluebutton#1593)

* Fixed invalid token for password reset (bigbluebutton#1632)

* HELP_URL env variable now works as expected (bigbluebutton#1636)

* bigbluebutton#1372 Fix for long Text in Table + Remove invalid HTML Tag (bigbluebutton#1403)

* removed invalid HTML Tag

* removed invalid HTML Tag

* Update _public_recording_row.html.erb

* Update _recording_row.html.erb

* Update _server_recording_row.html.erb

form-inline replaced by own css

* Update _server_room_row.html.erb

* Update _public_recording_row.html.erb

* Update _recording_row.html.erb

* Update _public_recording_row.html.erb

* Update _recordings.html.erb

* Update _rooms.html.erb

* Update main.scss

fix for long text

* Update main.scss

* Update _public_recording_row.html.erb

* Added more validation on profile image (bigbluebutton#1644)

* Users who can't create rooms but have shared rooms now have a different view (bigbluebutton#1649)

* Revert "Puma Worker Configuration (bigbluebutton#1332)" (bigbluebutton#1667)

This reverts commit 78ed8d7.

* Removed html safe from all flash messages (bigbluebutton#1668)

* Remove hardcoded guest=true if require mod approval is set (bigbluebutton#1669)

* Change random generation for room uid (bigbluebutton#1670)

* GRN2-290: Update gems and update to Rails 5.2.4.3 (bigbluebutton#1671)

* Update gems and update to Rails 5.2.4.3

* remove gemfile error

Co-authored-by: MrKeksi <[email protected]>
Co-authored-by: Florian Weber <[email protected]>
Co-authored-by: Stefan Weil <[email protected]>
Co-authored-by: Lars Kiesow <[email protected]>
Co-authored-by: Dave Lane <[email protected]>
Co-authored-by: Dave Lane <[email protected]>
Co-authored-by: Henning <[email protected]>
Co-authored-by: Marcel Waldvogel <[email protected]>
Co-authored-by: Christian Marg <[email protected]>
Co-authored-by: Klaus <[email protected]>

.rubocop.yml

@@ -73,11 +73,11 @@ Style/RescueStandardError:
   Enabled: false
 
 # Align the elements of a hash literal if they span more than one line.
-Layout/AlignHash:
+Layout/HashAlignment:
   Enabled: false
 
 # Align the parameters of a method definition if they span more than one line.
-Layout/AlignParameters:
+Layout/ParameterAlignment:
   Enabled: false
 
 # Align ends corresponding to defs correctly.
@@ -93,7 +93,7 @@ Layout/EmptyLineAfterGuardClause:
   Enabled: false
 
 # Align the arguments of a method call if they span more than one line.
-Layout/AlignArguments:
+Layout/ArgumentAlignment:
   Enabled: false
 
 #
@@ -120,7 +120,7 @@ Metrics/ClassLength:
   Enabled: false
 
 # Limit lines to 80 characters.
-Metrics/LineLength:
+Layout/LineLength:
   Max: 130
 
 # Avoid methods longer than 10 lines of code.
@@ -141,5 +141,39 @@ Metrics/CyclomaticComplexity:
   Max: 17
 
 # Checks for method parameter names that contain capital letters, end in numbers, or do not meet a minimal length.
-Naming/UncommunicativeMethodParamName:
-  Enabled: false
+Naming/MethodParameterName:
+  Enabled: false
+
+Lint/LiteralInInterpolation:
+  Enabled: false
+
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+
+Lint/RaiseException:
+  Enabled: true
+
+Lint/StructNewOverride:
+  Enabled: true
+
+Style/ExponentialNotation:
+  Enabled: true
+
+Style/HashEachMethods:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true
+
+Style/SlicingWithRange:
+  Enabled: true
+

Gemfile

@@ -8,7 +8,7 @@ git_source(:github) do |repo_name|
 end
 
 # Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
-gem 'rails', '~> 5.2.3'
+gem 'rails', '~> 5.2.4.3'
 
 # Use Puma as the app server
 gem 'puma', '~> 3.12'
@@ -44,6 +44,8 @@ gem 'bcrypt', '~> 3.1.7'
 # Reduces boot times through caching; required in config/boot.rb
 gem 'bootsnap', '>= 1.1.0', require: false
 
+gem 'sprockets', '< 4.0.0'
+
 # Authentication.
 gem 'omniauth'
 gem 'omniauth-twitter'