Update knockout-postbox.js #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new function to dispose all topics by topic name
|
Thanks for this PR. It will need some tests and README updates as well. I'll try to get to them, if you don't get to them first. |
|
|
||
| //dispose all subscriptions by topic name. | ||
| exports.disposeTopic = function (topic) { | ||
| var sub = subscriptions[topic]; |
There was a problem hiding this comment.
@rniemeyer Arent subscriptions accessed using the subscription id instead of the topic ?
Compare https://github.com/rniemeyer/knockout-postbox/blob/master/src/knockout-postbox.js#L53 with this line...
Sorry, I am currently not in the situation to test this so I can be totally incorrect. In that case, just ignore my comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am doing a large knockout application and I had to implement this function, to dispose topics by topic name, it is very useful for handling dispose event and cleaning after yourself.
If it possible can you add it to the repo so I don't need to maintain a copy of the library/
Regards
Erik.
Added new function to dispose all topics by topic name.